Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Unified Diff: net/udp/udp_socket_unittest.cc

Issue 1513043002: clang/win: Let remaining chromium_code targets build with -Wextra. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_auth_sspi_win_unittest.cc ('k') | printing/printing_context_win_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/udp/udp_socket_unittest.cc
diff --git a/net/udp/udp_socket_unittest.cc b/net/udp/udp_socket_unittest.cc
index 28431e40e41c54bc4b9370c0b1c51a7200cdf3d8..9b7b684314f7f9352c1d43237536265e746e15d9 100644
--- a/net/udp/udp_socket_unittest.cc
+++ b/net/udp/udp_socket_unittest.cc
@@ -715,8 +715,8 @@ BOOL WINAPI FakeQOSAddSocketToFlow(HANDLE handle,
PQOS_FLOWID flow_id) {
EXPECT_EQ(kFakeHandle, handle);
EXPECT_EQ(NULL, addr);
- EXPECT_EQ(QOS_NON_ADAPTIVE_FLOW, flags);
- EXPECT_EQ(0, *flow_id);
+ EXPECT_EQ(static_cast<DWORD>(QOS_NON_ADAPTIVE_FLOW), flags);
+ EXPECT_EQ(0u, *flow_id);
*flow_id = kFakeFlowId;
return true;
}
@@ -726,9 +726,9 @@ BOOL WINAPI FakeQOSRemoveSocketFromFlow(HANDLE handle,
QOS_FLOWID flowid,
DWORD reserved) {
EXPECT_EQ(kFakeHandle, handle);
- EXPECT_EQ(NULL, socket);
+ EXPECT_EQ(0u, socket);
EXPECT_EQ(kFakeFlowId, flowid);
- EXPECT_EQ(0, reserved);
+ EXPECT_EQ(0u, reserved);
return true;
}
@@ -746,7 +746,7 @@ BOOL WINAPI FakeQOSSetFlow(HANDLE handle,
EXPECT_EQ(sizeof(DWORD), size);
EXPECT_EQ(g_expected_dscp, *reinterpret_cast<DWORD*>(data));
EXPECT_EQ(kFakeFlowId, flow_id);
- EXPECT_EQ(0, reserved);
+ EXPECT_EQ(0u, reserved);
EXPECT_EQ(NULL, overlapped);
return true;
}
« no previous file with comments | « net/http/http_auth_sspi_win_unittest.cc ('k') | printing/printing_context_win_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698