clang/win: Let remaining chromium_code targets build with -Wextra.

media/audio/win/core_audio_util_win_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/memory/scoped_ptr.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/synchronization/waitable_event.h"
 #include "base/win/scoped_co_mem.h"
 #include "base/win/scoped_com_initializer.h"
 #include "base/win/scoped_handle.h"
@@ skipping 55 matching lines @@
     {eRender, eConsole},
     {eRender, eCommunications},
     {eRender, eMultimedia},
     {eCapture, eConsole},
     {eCapture, eCommunications},
     {eCapture, eMultimedia}
   };
 
   // Create default devices for all flow/role combinations above.
   ScopedComPtr<IMMDevice> audio_device;
-  for (int i = 0; i < arraysize(data); ++i) {
+  for (size_t i = 0; i < arraysize(data); ++i) {
     audio_device =
         CoreAudioUtil::CreateDefaultDevice(data[i].flow, data[i].role);
     EXPECT_TRUE(audio_device.get());
     EXPECT_EQ(data[i].flow, CoreAudioUtil::GetDataFlow(audio_device.get()));
   }
 
   // Only eRender and eCapture are allowed as flow parameter.
   audio_device = CoreAudioUtil::CreateDefaultDevice(eAll, eConsole);
   EXPECT_FALSE(audio_device.get());
 }
@@ skipping 31 matching lines @@
   } data[] = {
     {eRender, eConsole},
     {eRender, eCommunications},
     {eCapture, eConsole},
     {eCapture, eCommunications}
   };
 
   // Get name and ID of default devices for all flow/role combinations above.
   ScopedComPtr<IMMDevice> audio_device;
   AudioDeviceName device_name;
-  for (int i = 0; i < arraysize(data); ++i) {
+  for (size_t i = 0; i < arraysize(data); ++i) {
     audio_device =
         CoreAudioUtil::CreateDefaultDevice(data[i].flow, data[i].role);
     EXPECT_TRUE(SUCCEEDED(
         CoreAudioUtil::GetDeviceName(audio_device.get(), &device_name)));
     EXPECT_FALSE(device_name.device_name.empty());
     EXPECT_FALSE(device_name.unique_id.empty());
   }
 }
 
 TEST_F(CoreAudioUtilWinTest, GetAudioControllerID) {
   ABORT_AUDIO_TEST_IF_NOT(DevicesAvailable());
 
   ScopedComPtr<IMMDeviceEnumerator> enumerator(
       CoreAudioUtil::CreateDeviceEnumerator());
   ASSERT_TRUE(enumerator.get());
 
   // Enumerate all active input and output devices and fetch the ID of
   // the associated device.
   EDataFlow flows[] = { eRender , eCapture };
-  for (int i = 0; i < arraysize(flows); ++i) {
+  for (size_t i = 0; i < arraysize(flows); ++i) {
     ScopedComPtr<IMMDeviceCollection> collection;
     ASSERT_TRUE(SUCCEEDED(enumerator->EnumAudioEndpoints(flows[i],
         DEVICE_STATE_ACTIVE, collection.Receive())));
     UINT count = 0;
     collection->GetCount(&count);
     for (UINT j = 0; j < count; ++j) {
       ScopedComPtr<IMMDevice> device;
       collection->Item(j, device.Receive());
       std::string controller_id(
           CoreAudioUtil::GetAudioControllerID(device.get(), enumerator.get()));
@@ skipping 39 matching lines @@
   const std::string id = name.unique_id;
   EXPECT_TRUE(CoreAudioUtil::DeviceIsDefault(eRender, eConsole, id));
   EXPECT_FALSE(CoreAudioUtil::DeviceIsDefault(eCapture, eConsole, id));
 }
 
 TEST_F(CoreAudioUtilWinTest, CreateDefaultClient) {
   ABORT_AUDIO_TEST_IF_NOT(DevicesAvailable());
 
   EDataFlow data[] = {eRender, eCapture};
 
-  for (int i = 0; i < arraysize(data); ++i) {
+  for (size_t i = 0; i < arraysize(data); ++i) {
     ScopedComPtr<IAudioClient> client;
     client = CoreAudioUtil::CreateDefaultClient(data[i], eConsole);
     EXPECT_TRUE(client.get());
   }
 }
 
 TEST_F(CoreAudioUtilWinTest, CreateClient) {
   ABORT_AUDIO_TEST_IF_NOT(DevicesAvailable());
 
   EDataFlow data[] = {eRender, eCapture};
 
-  for (int i = 0; i < arraysize(data); ++i) {
+  for (size_t i = 0; i < arraysize(data); ++i) {
     ScopedComPtr<IMMDevice> device;
     ScopedComPtr<IAudioClient> client;
     device = CoreAudioUtil::CreateDefaultDevice(data[i], eConsole);
     EXPECT_TRUE(device.get());
     EXPECT_EQ(data[i], CoreAudioUtil::GetDataFlow(device.get()));
     client = CoreAudioUtil::CreateClient(device.get());
     EXPECT_TRUE(client.get());
   }
 }
 
@@ skipping 44 matching lines @@
   }
 }
 
 TEST_F(CoreAudioUtilWinTest, GetDevicePeriod) {
   ABORT_AUDIO_TEST_IF_NOT(DevicesAvailable());
 
   EDataFlow data[] = {eRender, eCapture};
 
   // Verify that the device periods are valid for the default render and
   // capture devices.
-  for (int i = 0; i < arraysize(data); ++i) {
+  for (size_t i = 0; i < arraysize(data); ++i) {
     ScopedComPtr<IAudioClient> client;
     REFERENCE_TIME shared_time_period = 0;
     REFERENCE_TIME exclusive_time_period = 0;
     client = CoreAudioUtil::CreateDefaultClient(data[i], eConsole);
     EXPECT_TRUE(client.get());
     EXPECT_TRUE(SUCCEEDED(CoreAudioUtil::GetDevicePeriod(
         client.get(), AUDCLNT_SHAREMODE_SHARED, &shared_time_period)));
     EXPECT_GT(shared_time_period, 0);
     EXPECT_TRUE(SUCCEEDED(CoreAudioUtil::GetDevicePeriod(
         client.get(), AUDCLNT_SHAREMODE_EXCLUSIVE, &exclusive_time_period)));
     EXPECT_GT(exclusive_time_period, 0);
     EXPECT_LE(exclusive_time_period, shared_time_period);
   }
 }
 
 TEST_F(CoreAudioUtilWinTest, GetPreferredAudioParameters) {
   ABORT_AUDIO_TEST_IF_NOT(DevicesAvailable());
 
   EDataFlow data[] = {eRender, eCapture};
 
   // Verify that the preferred audio parameters are OK for the default render
   // and capture devices.
-  for (int i = 0; i < arraysize(data); ++i) {
+  for (size_t i = 0; i < arraysize(data); ++i) {
     ScopedComPtr<IAudioClient> client;
     AudioParameters params;
     client = CoreAudioUtil::CreateDefaultClient(data[i], eConsole);
     EXPECT_TRUE(client.get());
     EXPECT_TRUE(SUCCEEDED(
         CoreAudioUtil::GetPreferredAudioParameters(client.get(), &params)));
     EXPECT_TRUE(params.IsValid());
   }
 }
 
@@ skipping 60 matching lines @@
 }
 
 TEST_F(CoreAudioUtilWinTest, CreateRenderAndCaptureClients) {
   ABORT_AUDIO_TEST_IF_NOT(DevicesAvailable());
 
   EDataFlow data[] = {eRender, eCapture};
 
   WAVEFORMATPCMEX format;
   uint32 endpoint_buffer_size = 0;
 
-  for (int i = 0; i < arraysize(data); ++i) {
+  for (size_t i = 0; i < arraysize(data); ++i) {
     ScopedComPtr<IAudioClient> client;
     ScopedComPtr<IAudioRenderClient> render_client;
     ScopedComPtr<IAudioCaptureClient> capture_client;
 
     client = CoreAudioUtil::CreateDefaultClient(data[i], eConsole);
     EXPECT_TRUE(client.get());
     EXPECT_TRUE(SUCCEEDED(
         CoreAudioUtil::GetSharedModeMixFormat(client.get(), &format)));
     if (data[i] == eRender) {
       // It is not possible to create a render client using an unitialized
@@ skipping 91 matching lines @@
 }
 
 TEST_F(CoreAudioUtilWinTest, GetDefaultOutputDeviceID) {
   ABORT_AUDIO_TEST_IF_NOT(DevicesAvailable());
 
   std::string default_device_id(CoreAudioUtil::GetDefaultOutputDeviceID());
   EXPECT_FALSE(default_device_id.empty());
 }
 
 }  // namespace media