clang/win: Let remaining chromium_code targets build with -Wextra.

chrome/common/safe_browsing/binary_feature_extractor_win_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/safe_browsing/binary_feature_extractor.h"
 
 #include <string>
 #include <vector>
 
 #include "base/base_paths.h"
@@ skipping 38 matching lines @@
 
 TEST_F(BinaryFeatureExtractorWinTest, UntrustedSignedBinary) {
   // signed.exe is signed by an untrusted root CA.
   ClientDownloadRequest_SignatureInfo signature_info;
   binary_feature_extractor_->CheckSignature(
       testdata_path_.Append(L"signed.exe"),
       &signature_info);
   ASSERT_EQ(1, signature_info.certificate_chain_size());
   std::vector<scoped_refptr<net::X509Certificate> > certs;
   ParseCertificateChain(signature_info.certificate_chain(0), &certs);
-  ASSERT_EQ(2, certs.size());
+  ASSERT_EQ(2u, certs.size());
   EXPECT_EQ("Joe's-Software-Emporium", certs[0]->subject().common_name);
   EXPECT_EQ("Root Agency", certs[1]->subject().common_name);
 
   EXPECT_TRUE(signature_info.has_trusted());
   EXPECT_FALSE(signature_info.trusted());
 }
 
 TEST_F(BinaryFeatureExtractorWinTest, TrustedBinary) {
   // wow_helper.exe is signed using Google's signing certifiacte.
   ClientDownloadRequest_SignatureInfo signature_info;
   binary_feature_extractor_->CheckSignature(
       testdata_path_.Append(L"wow_helper.exe"),
       &signature_info);
   ASSERT_EQ(1, signature_info.certificate_chain_size());
   std::vector<scoped_refptr<net::X509Certificate> > certs;
   ParseCertificateChain(signature_info.certificate_chain(0), &certs);
-  ASSERT_EQ(3, certs.size());
+  ASSERT_EQ(3u, certs.size());
 
   EXPECT_EQ("Google Inc", certs[0]->subject().common_name);
   EXPECT_EQ("VeriSign Class 3 Code Signing 2009-2 CA",
             certs[1]->subject().common_name);
   EXPECT_EQ("Class 3 Public Primary Certification Authority",
             certs[2]->subject().organization_unit_names[0]);
 
   EXPECT_TRUE(signature_info.trusted());
 }
 
@@ skipping 66 matching lines @@
       nullptr /* signed_data */));
   EXPECT_TRUE(image_headers.has_pe_headers());
   const ClientDownloadRequest_PEImageHeaders& pe_headers =
       image_headers.pe_headers();
   EXPECT_TRUE(pe_headers.has_dos_header());
   EXPECT_TRUE(pe_headers.has_file_header());
   EXPECT_TRUE(pe_headers.has_optional_headers32());
   EXPECT_FALSE(pe_headers.has_optional_headers64());
   EXPECT_NE(0, pe_headers.section_header_size());
   EXPECT_TRUE(pe_headers.has_export_section_data());
-  EXPECT_EQ(1U, pe_headers.debug_data_size());
+  EXPECT_EQ(1, pe_headers.debug_data_size());
 }
 
 TEST_F(BinaryFeatureExtractorWinTest, ExtractImageFeaturesWithoutExports) {
   // Test extracting headers from something that is a PE image with debug data.
   ClientDownloadRequest_ImageHeaders image_headers;
   ASSERT_TRUE(binary_feature_extractor_->ExtractImageFeatures(
       testdata_path_.DirName().AppendASCII("module_with_exports_x86.dll"),
       BinaryFeatureExtractor::kOmitExports, &image_headers,
       nullptr /* signed_data */));
   EXPECT_TRUE(image_headers.has_pe_headers());
   const ClientDownloadRequest_PEImageHeaders& pe_headers =
       image_headers.pe_headers();
   EXPECT_TRUE(pe_headers.has_dos_header());
   EXPECT_TRUE(pe_headers.has_file_header());
   EXPECT_TRUE(pe_headers.has_optional_headers32());
   EXPECT_FALSE(pe_headers.has_optional_headers64());
   EXPECT_NE(0, pe_headers.section_header_size());
   EXPECT_FALSE(pe_headers.has_export_section_data());
-  EXPECT_EQ(1U, pe_headers.debug_data_size());
+  EXPECT_EQ(1, pe_headers.debug_data_size());
 }
 
 TEST_F(BinaryFeatureExtractorWinTest, ExtractImageFeaturesUntrustedSigned) {
   // Test extracting features from a signed PE image.
   ClientDownloadRequest_ImageHeaders image_headers;
   google::protobuf::RepeatedPtrField<std::string> signed_data;
   ASSERT_TRUE(binary_feature_extractor_->ExtractImageFeatures(
       testdata_path_.AppendASCII("signed.exe"),
       BinaryFeatureExtractor::kDefaultOptions, &image_headers, &signed_data));
   ASSERT_EQ(1, signed_data.size());
   ASSERT_LT(0U, signed_data.Get(0).size());
 }
 
 TEST_F(BinaryFeatureExtractorWinTest, ExtractImageFeaturesTrustedSigned) {
   // Test extracting features from a signed PE image from a trusted root.
   ClientDownloadRequest_ImageHeaders image_headers;
   google::protobuf::RepeatedPtrField<std::string> signed_data;
   ASSERT_TRUE(binary_feature_extractor_->ExtractImageFeatures(
       testdata_path_.AppendASCII("wow_helper.exe"),
       BinaryFeatureExtractor::kDefaultOptions, &image_headers, &signed_data));
   ASSERT_EQ(1, signed_data.size());
   ASSERT_LT(0U, signed_data.Get(0).size());
 }
 
 }  // namespace safe_browsing