chrome/browser/importer/ie_importer_browsertest_win.cc - Issue 1513043002: clang/win: Let remaining chromium_code targets build with -Wextra.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/importer/ie_importer_browsertest_win.cc

Issue 1513043002: clang/win: Let remaining chromium_code targets build with -Wextra. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/autocomplete/in_memory_url_index_unittest.cc ('k') | chrome/browser/media_galleries/fileapi/iapps_finder_impl_win_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/importer/ie_importer_browsertest_win.cc

diff --git a/chrome/browser/importer/ie_importer_browsertest_win.cc b/chrome/browser/importer/ie_importer_browsertest_win.cc

index 800d726385e96839c74d572ab4da78a386c9ecf1..7bf6aa81ca391383056932e34a0e8b8dac52af06 100644

--- a/chrome/browser/importer/ie_importer_browsertest_win.cc

+++ b/chrome/browser/importer/ie_importer_browsertest_win.cc

@@ -246,11 +246,11 @@ class TestObserver : public ProfileWriter,

EXPECT_EQ(arraysize(kIEFaviconGroup), favicon_count_);

}

if (importer_items_ & importer::HISTORY)

- EXPECT_EQ(2, history_count_);

+ EXPECT_EQ(2u, history_count_);

if (importer_items_ & importer::HOME_PAGE)

- EXPECT_EQ(1, homepage_count_);

+ EXPECT_EQ(1u, homepage_count_);

if ((importer_items_ & importer::PASSWORDS) && (ie_version_ == IE7))

- EXPECT_EQ(1, ie7_password_count_);

+ EXPECT_EQ(1u, ie7_password_count_);

// We need to test the IE6 password importer code.

// https://crbug.com/257100

// EXPECT_EQ(1, password_count_);

@@ -352,7 +352,7 @@ class TestObserver : public ProfileWriter,

if (ie_version_ == IE7) {

EXPECT_EQ(L"Test1", info.url_hash);

EXPECT_EQ(1, info.encrypted_data[0]);

- EXPECT_EQ(4, info.encrypted_data.size());

+ EXPECT_EQ(4u, info.encrypted_data.size());

++ie7_password_count_;

}