components/browser_watcher/exit_code_watcher_win_unittest.cc - Issue 1513043002: clang/win: Let remaining chromium_code targets build with -Wextra.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/browser_watcher/exit_code_watcher_win_unittest.cc

Issue 1513043002: clang/win: Let remaining chromium_code targets build with -Wextra. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/browser_watcher/endsession_watcher_window_win_unittest.cc ('k') | components/browser_watcher/exit_funnel_win_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/browser_watcher/exit_code_watcher_win_unittest.cc

diff --git a/components/browser_watcher/exit_code_watcher_win_unittest.cc b/components/browser_watcher/exit_code_watcher_win_unittest.cc

index 118cf770a3d3b7190b0b8f807aafaef1ddb71a80..df7de86767eeb329fb0e023074cd8cbc1e771047 100644

--- a/components/browser_watcher/exit_code_watcher_win_unittest.cc

+++ b/components/browser_watcher/exit_code_watcher_win_unittest.cc

@@ -92,7 +92,7 @@ class ExitCodeWatcherTest : public testing::Test {

base::win::RegistryValueIterator it(

HKEY_CURRENT_USER, kRegistryPath);

- ASSERT_EQ(1, it.ValueCount());

+ ASSERT_EQ(1u, it.ValueCount());

base::win::RegKey key(HKEY_CURRENT_USER,

kRegistryPath,

KEY_QUERY_VALUE);

@@ -104,7 +104,7 @@ class ExitCodeWatcherTest : public testing::Test {

base::CompareCase::SENSITIVE));

DWORD value = 0;

ASSERT_EQ(ERROR_SUCCESS, key.ReadValueDW(it.Name(), &value));

- ASSERT_EQ(exit_code, value);

+ ASSERT_EQ(exit_code, static_cast<int>(value));

}

protected: