Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1457543003: Add ShaderBuilders to EmitArgs and remove gettings from ProgBuilder. (Closed)

Created:
5 years, 1 month ago by egdaniel
Modified:
5 years, 1 month ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add ShaderBuilders to EmitArgs and remove gettings from ProgBuilder. BUG=skia: Committed: https://skia.googlesource.com/skia/+/4ca2e6034365ad280ec64473f7f1d72ebd8335e4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1521 lines, -1302 lines) Patch
M experimental/SkPerlinNoiseShader2/SkPerlinNoiseShader2.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M gm/dcshader.cpp View 1 chunk +11 lines, -10 lines 0 comments Download
M src/core/SkLightingShader.cpp View 2 chunks +17 lines, -15 lines 0 comments Download
M src/effects/GrCircleBlurFragmentProcessor.cpp View 1 chunk +10 lines, -10 lines 0 comments Download
M src/effects/SkAlphaThresholdFilter.cpp View 1 chunk +34 lines, -34 lines 0 comments Download
M src/effects/SkArithmeticMode_gpu.cpp View 5 chunks +25 lines, -19 lines 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 3 chunks +52 lines, -50 lines 0 comments Download
M src/effects/SkColorCubeFilter.cpp View 1 chunk +15 lines, -15 lines 0 comments Download
M src/effects/SkColorMatrixFilter.cpp View 1 chunk +11 lines, -11 lines 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 2 chunks +21 lines, -20 lines 0 comments Download
M src/effects/SkLightingImageFilter.cpp View 20 chunks +93 lines, -79 lines 0 comments Download
M src/effects/SkLumaColorFilter.cpp View 1 chunk +8 lines, -8 lines 0 comments Download
M src/effects/SkMagnifierImageFilter.cpp View 1 chunk +30 lines, -30 lines 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 2 chunks +17 lines, -17 lines 0 comments Download
M src/effects/SkPerlinNoiseShader.cpp View 11 chunks +51 lines, -51 lines 0 comments Download
M src/effects/SkTableColorFilter.cpp View 1 chunk +23 lines, -23 lines 0 comments Download
M src/effects/gradients/SkGradientShader.cpp View 1 chunk +31 lines, -31 lines 0 comments Download
M src/effects/gradients/SkGradientShaderPriv.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/effects/gradients/SkLinearGradient.cpp View 1 chunk +6 lines, -2 lines 0 comments Download
M src/effects/gradients/SkRadialGradient.cpp View 1 chunk +6 lines, -2 lines 0 comments Download
M src/effects/gradients/SkSweepGradient.cpp View 2 chunks +6 lines, -3 lines 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient_gpu.cpp View 8 chunks +75 lines, -50 lines 0 comments Download
M src/gpu/GrDefaultGeoProcFactory.cpp View 2 chunks +32 lines, -15 lines 0 comments Download
M src/gpu/GrFragmentProcessor.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 3 chunks +95 lines, -76 lines 0 comments Download
M src/gpu/GrPathProcessor.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/batches/GrAAConvexPathRenderer.cpp View 1 chunk +31 lines, -27 lines 0 comments Download
M src/gpu/effects/GrBezierEffect.cpp View 7 chunks +177 lines, -141 lines 0 comments Download
M src/gpu/effects/GrBicubicEffect.cpp View 1 chunk +22 lines, -19 lines 0 comments Download
M src/gpu/effects/GrBitmapTextGeoProc.cpp View 2 chunks +29 lines, -24 lines 0 comments Download
M src/gpu/effects/GrConfigConversionEffect.cpp View 3 chunks +12 lines, -12 lines 0 comments Download
M src/gpu/effects/GrConstColorProcessor.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/effects/GrConvexPolyEffect.cpp View 2 chunks +28 lines, -28 lines 0 comments Download
M src/gpu/effects/GrConvolutionEffect.cpp View 2 chunks +12 lines, -12 lines 0 comments Download
M src/gpu/effects/GrCoverageSetOpXP.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/gpu/effects/GrCustomXfermode.cpp View 1 chunk +12 lines, -9 lines 0 comments Download
M src/gpu/effects/GrDashingEffect.cpp View 2 chunks +61 lines, -51 lines 0 comments Download
M src/gpu/effects/GrDisableColorXP.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldGeoProc.cpp View 10 chunks +164 lines, -139 lines 0 comments Download
M src/gpu/effects/GrDitherEffect.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M src/gpu/effects/GrMatrixConvolutionEffect.cpp View 1 chunk +19 lines, -20 lines 0 comments Download
M src/gpu/effects/GrOvalEffect.cpp View 3 chunks +24 lines, -24 lines 0 comments Download
M src/gpu/effects/GrPorterDuffXferProcessor.cpp View 4 chunks +24 lines, -21 lines 0 comments Download
M src/gpu/effects/GrRRectEffect.cpp View 6 chunks +94 lines, -86 lines 0 comments Download
M src/gpu/effects/GrSimpleTextureEffect.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M src/gpu/effects/GrTextureDomain.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/gpu/effects/GrXfermodeFragmentProcessor.cpp View 4 chunks +14 lines, -10 lines 0 comments Download
M src/gpu/effects/GrYUVtoRGBEffect.cpp View 1 chunk +11 lines, -11 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.cpp View 4 chunks +6 lines, -5 lines 0 comments Download
M src/gpu/glsl/GrGLSLFragmentProcessor.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/gpu/glsl/GrGLSLFragmentProcessor.cpp View 2 chunks +12 lines, -11 lines 0 comments Download
M src/gpu/glsl/GrGLSLGeometryProcessor.h View 3 chunks +10 lines, -3 lines 0 comments Download
M src/gpu/glsl/GrGLSLGeometryProcessor.cpp View 4 chunks +12 lines, -12 lines 0 comments Download
M src/gpu/glsl/GrGLSLPrimitiveProcessor.h View 5 chunks +9 lines, -0 lines 0 comments Download
M src/gpu/glsl/GrGLSLPrimitiveProcessor.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/glsl/GrGLSLProgramBuilder.h View 4 chunks +0 lines, -11 lines 0 comments Download
M src/gpu/glsl/GrGLSLXferProcessor.h View 5 chunks +5 lines, -0 lines 0 comments Download
M src/gpu/glsl/GrGLSLXferProcessor.cpp View 3 chunks +24 lines, -20 lines 0 comments Download
M tests/GLProgramsTest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Dependent Patchsets:

Issue 1453623003 Patch 1

Messages

Total messages: 6 (2 generated)
egdaniel
The crux of this change is removing accesses to Vertex/FragmentBuilder from the ProgramBuilder and thus ...
5 years, 1 month ago (2015-11-17 21:15:17 UTC) #2
ethannicholas
On 2015/11/17 21:15:17, egdaniel wrote: > The crux of this change is removing accesses to ...
5 years, 1 month ago (2015-11-17 21:43:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1457543003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1457543003/1
5 years, 1 month ago (2015-11-18 15:46:53 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-11-18 16:01:30 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/4ca2e6034365ad280ec64473f7f1d72ebd8335e4

Powered by Google App Engine
This is Rietveld 408576698