Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1453623003: Move glsl onto EmitArgs struct for emitCode (Closed)

Created:
5 years, 1 month ago by egdaniel
Modified:
5 years, 1 month ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@moveShaders
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Move glsl onto EmitArgs struct for emitCode BUG=skia: Committed: https://skia.googlesource.com/skia/+/a2e3e0f7f8ceed2ab152428d7ee2812ad8c842c3

Patch Set 1 #

Total comments: 1

Patch Set 2 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -28 lines) Patch
M src/effects/SkBlurMaskFilter.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 1 chunk +5 lines, -1 line 0 comments Download
M src/effects/gradients/SkGradientShader.cpp View 1 3 chunks +4 lines, -2 lines 0 comments Download
M src/effects/gradients/SkGradientShaderPriv.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/effects/gradients/SkLinearGradient.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/effects/gradients/SkRadialGradient.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/effects/gradients/SkSweepGradient.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient_gpu.cpp View 5 chunks +5 lines, -0 lines 0 comments Download
M src/gpu/effects/GrBicubicEffect.cpp View 1 chunk +6 lines, -1 line 0 comments Download
M src/gpu/effects/GrConfigConversionEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrDistanceFieldGeoProc.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/effects/GrMatrixConvolutionEffect.cpp View 2 chunks +12 lines, -2 lines 0 comments Download
M src/gpu/effects/GrTextureDomain.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/effects/GrTextureDomain.cpp View 4 chunks +10 lines, -4 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.cpp View 3 chunks +18 lines, -4 lines 0 comments Download
M src/gpu/glsl/GrGLSLFragmentProcessor.h View 3 chunks +3 lines, -0 lines 0 comments Download
M src/gpu/glsl/GrGLSLFragmentProcessor.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/glsl/GrGLSLPrimitiveProcessor.h View 4 chunks +5 lines, -1 line 0 comments Download
M src/gpu/glsl/GrGLSLProgramBuilder.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/glsl/GrGLSLXferProcessor.h View 4 chunks +6 lines, -2 lines 0 comments Download

Dependent Patchsets:

Issue 1462123003 Patch 1
Issue 1462123003 Patch 20001
Issue 1462123003 Patch 40001
Issue 1462123003 Patch 60001

Messages

Total messages: 9 (4 generated)
egdaniel
This is a step to not sending the program builder to the processors' emitCode
5 years, 1 month ago (2015-11-17 22:08:13 UTC) #2
joshualitt
On 2015/11/17 22:08:13, egdaniel wrote: > This is a step to not sending the program ...
5 years, 1 month ago (2015-11-18 15:36:01 UTC) #3
joshualitt
https://codereview.chromium.org/1453623003/diff/1/src/effects/gradients/SkGradientShader.cpp File src/effects/gradients/SkGradientShader.cpp (right): https://codereview.chromium.org/1453623003/diff/1/src/effects/gradients/SkGradientShader.cpp#newcode1046 src/effects/gradients/SkGradientShader.cpp:1046: // shader as thekBeforeIterp case). This same optimization applies ...
5 years, 1 month ago (2015-11-18 17:42:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1453623003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1453623003/20001
5 years, 1 month ago (2015-11-19 14:13:11 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 15:23:48 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/a2e3e0f7f8ceed2ab152428d7ee2812ad8c842c3

Powered by Google App Engine
This is Rietveld 408576698