Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 867213004: remove prototype pathops code (Closed)

Created:
5 years, 10 months ago by caryclark
Modified:
5 years, 10 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

The original instantiation of pathops was in the experimental/Intersection directory. Anything of value has been copied into the mainline. The obsolete gyp files are also included, along with a pixman test that never functioned but accidentally referenced some of these deleted files. Committed: https://skia.googlesource.com/skia/+/17a2b5473d0144d10749ef8d26a10fbdab580226

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -59965 lines) Patch
D experimental/Intersection/ActiveEdge_Test.cpp View 1 chunk +0 lines, -83 lines 0 comments Download
D experimental/Intersection/AddTestOutput/main.cpp View 1 chunk +0 lines, -115 lines 0 comments Download
D experimental/Intersection/ConvexHull.cpp View 1 chunk +0 lines, -143 lines 0 comments Download
D experimental/Intersection/ConvexHull_Test.cpp View 1 chunk +0 lines, -468 lines 0 comments Download
D experimental/Intersection/CubeRoot.cpp View 1 chunk +0 lines, -400 lines 0 comments Download
D experimental/Intersection/CubicBezierClip.cpp View 1 chunk +0 lines, -89 lines 0 comments Download
D experimental/Intersection/CubicBezierClip_Test.cpp View 1 chunk +0 lines, -32 lines 0 comments Download
D experimental/Intersection/CubicBounds.cpp View 1 chunk +0 lines, -66 lines 0 comments Download
D experimental/Intersection/CubicConvexHull.cpp View 1 chunk +0 lines, -165 lines 0 comments Download
D experimental/Intersection/CubicIntersection.cpp View 1 chunk +0 lines, -471 lines 0 comments Download
D experimental/Intersection/CubicIntersection_Test.cpp View 1 chunk +0 lines, -778 lines 0 comments Download
D experimental/Intersection/CubicIntersection_TestData.h View 1 chunk +0 lines, -31 lines 0 comments Download
D experimental/Intersection/CubicIntersection_TestData.cpp View 1 chunk +0 lines, -310 lines 0 comments Download
D experimental/Intersection/CubicLineSegments.h View 1 chunk +0 lines, -12 lines 0 comments Download
D experimental/Intersection/CubicLineSegments.cpp View 1 chunk +0 lines, -38 lines 0 comments Download
D experimental/Intersection/CubicParameterization.cpp View 1 chunk +0 lines, -518 lines 0 comments Download
D experimental/Intersection/CubicParameterizationCode.cpp View 1 chunk +0 lines, -405 lines 0 comments Download
D experimental/Intersection/CubicParameterization_Test.cpp View 1 chunk +0 lines, -113 lines 0 comments Download
D experimental/Intersection/CubicParameterization_TestUtility.cpp View 1 chunk +0 lines, -53 lines 0 comments Download
D experimental/Intersection/CubicReduceOrder.cpp View 1 chunk +0 lines, -254 lines 0 comments Download
D experimental/Intersection/CubicReduceOrder_Test.cpp View 1 chunk +0 lines, -154 lines 0 comments Download
D experimental/Intersection/CubicSubDivide.cpp View 1 chunk +0 lines, -147 lines 0 comments Download
D experimental/Intersection/CubicToQuadratics.cpp View 1 chunk +0 lines, -217 lines 0 comments Download
D experimental/Intersection/CubicToQuadratics_Test.cpp View 1 chunk +0 lines, -269 lines 0 comments Download
D experimental/Intersection/CubicUtilities.h View 1 chunk +0 lines, -46 lines 0 comments Download
D experimental/Intersection/CubicUtilities.cpp View 1 chunk +0 lines, -424 lines 0 comments Download
D experimental/Intersection/CubicUtilities_Test.cpp View 1 chunk +0 lines, -28 lines 0 comments Download
D experimental/Intersection/CurveIntersection.h View 1 chunk +0 lines, -80 lines 0 comments Download
D experimental/Intersection/CurveUtilities.h View 1 chunk +0 lines, -15 lines 0 comments Download
D experimental/Intersection/DataTypes.h View 1 chunk +0 lines, -418 lines 0 comments Download
D experimental/Intersection/DataTypes.cpp View 1 chunk +0 lines, -108 lines 0 comments Download
D experimental/Intersection/DataTypes_Test.h View 1 chunk +0 lines, -7 lines 0 comments Download
D experimental/Intersection/EdgeDemo.h View 1 chunk +0 lines, -3 lines 0 comments Download
D experimental/Intersection/EdgeDemo.cpp View 1 chunk +0 lines, -347 lines 0 comments Download
D experimental/Intersection/EdgeDemoApp.mm View 1 chunk +0 lines, -94 lines 0 comments Download
D experimental/Intersection/EdgeDemoApp.xib View 1 chunk +0 lines, -3115 lines 0 comments Download
D experimental/Intersection/EdgeDemoApp-Info.plist View 1 chunk +0 lines, -32 lines 0 comments Download
D experimental/Intersection/EdgeMain.cpp View 1 chunk +0 lines, -13 lines 0 comments Download
D experimental/Intersection/EdgeWalker.cpp View 1 chunk +0 lines, -2705 lines 0 comments Download
D experimental/Intersection/EdgeWalkerPolygon4x4_Test.cpp View 1 chunk +0 lines, -290 lines 0 comments Download
D experimental/Intersection/EdgeWalkerPolygons_Mismatches.cpp View 1 chunk +0 lines, -1622 lines 0 comments Download
D experimental/Intersection/EdgeWalkerPolygons_Test.cpp View 1 chunk +0 lines, -790 lines 0 comments Download
D experimental/Intersection/EdgeWalkerQuadralaterals_Test.cpp View 1 chunk +0 lines, -126 lines 0 comments Download
D experimental/Intersection/EdgeWalkerQuadratic4x4_Test.cpp View 1 chunk +0 lines, -106 lines 0 comments Download
D experimental/Intersection/EdgeWalkerQuadratics_Test.cpp View 1 chunk +0 lines, -284 lines 0 comments Download
D experimental/Intersection/EdgeWalkerRectangles_Test.cpp View 1 chunk +0 lines, -469 lines 0 comments Download
D experimental/Intersection/EdgeWalker_Test.h View 1 chunk +0 lines, -59 lines 0 comments Download
D experimental/Intersection/EdgeWalker_TestUtility.cpp View 1 chunk +0 lines, -761 lines 0 comments Download
D experimental/Intersection/English.lproj/InfoPlist.strings View 1 chunk +0 lines, -2 lines 0 comments Download
D experimental/Intersection/English.lproj/MainMenu.xib View 1 chunk +0 lines, -4119 lines 0 comments Download
D experimental/Intersection/Extrema.h View 1 chunk +0 lines, -8 lines 0 comments Download
D experimental/Intersection/Extrema.cpp View 1 chunk +0 lines, -81 lines 0 comments Download
D experimental/Intersection/Inline_Tests.cpp View 1 chunk +0 lines, -54 lines 0 comments Download
D experimental/Intersection/IntersectionUtilities.h View 1 chunk +0 lines, -47 lines 0 comments Download
D experimental/Intersection/IntersectionUtilities.cpp View 1 chunk +0 lines, -48 lines 0 comments Download
D experimental/Intersection/Intersection_Tests.h View 1 chunk +0 lines, -61 lines 0 comments Download
D experimental/Intersection/Intersection_Tests.cpp View 1 chunk +0 lines, -84 lines 0 comments Download
D experimental/Intersection/Intersections.h View 1 chunk +0 lines, -144 lines 0 comments Download
D experimental/Intersection/Intersections.cpp View 1 chunk +0 lines, -158 lines 0 comments Download
D experimental/Intersection/LineCubicIntersection.cpp View 1 chunk +0 lines, -296 lines 0 comments Download
D experimental/Intersection/LineCubicIntersection_Test.cpp View 1 chunk +0 lines, -62 lines 0 comments Download
D experimental/Intersection/LineIntersection.h View 1 chunk +0 lines, -21 lines 0 comments Download
D experimental/Intersection/LineIntersection.cpp View 1 chunk +0 lines, -338 lines 0 comments Download
D experimental/Intersection/LineIntersection_Test.cpp View 1 chunk +0 lines, -72 lines 0 comments Download
D experimental/Intersection/LineParameterization.cpp View 1 chunk +0 lines, -63 lines 0 comments Download
D experimental/Intersection/LineParameters.h View 1 chunk +0 lines, -108 lines 0 comments Download
D experimental/Intersection/LineParameteters_Test.cpp View 1 chunk +0 lines, -79 lines 0 comments Download
D experimental/Intersection/LineQuadraticIntersection.cpp View 1 chunk +0 lines, -369 lines 0 comments Download
D experimental/Intersection/LineQuadraticIntersection_Test.cpp View 1 chunk +0 lines, -235 lines 0 comments Download
D experimental/Intersection/LineUtilities.h View 1 chunk +0 lines, -25 lines 0 comments Download
D experimental/Intersection/LineUtilities.cpp View 1 chunk +0 lines, -133 lines 0 comments Download
D experimental/Intersection/LogoPlay.cpp View 1 chunk +0 lines, -353 lines 0 comments Download
D experimental/Intersection/MiniSimplify_Test.cpp View 1 chunk +0 lines, -99 lines 0 comments Download
D experimental/Intersection/NearestPoint.cpp View 1 chunk +0 lines, -473 lines 0 comments Download
D experimental/Intersection/Parameterization_Test.h View 1 chunk +0 lines, -12 lines 0 comments Download
D experimental/Intersection/QuadraticBezierClip.cpp View 1 chunk +0 lines, -82 lines 0 comments Download
D experimental/Intersection/QuadraticBezierClip_Test.cpp View 1 chunk +0 lines, -70 lines 0 comments Download
D experimental/Intersection/QuadraticBounds.cpp View 1 chunk +0 lines, -47 lines 0 comments Download
D experimental/Intersection/QuadraticImplicit.cpp View 1 chunk +0 lines, -572 lines 0 comments Download
D experimental/Intersection/QuadraticIntersection.cpp View 1 chunk +0 lines, -403 lines 0 comments Download
D experimental/Intersection/QuadraticIntersection_Test.cpp View 1 chunk +0 lines, -436 lines 0 comments Download
D experimental/Intersection/QuadraticIntersection_TestData.h View 1 chunk +0 lines, -16 lines 0 comments Download
D experimental/Intersection/QuadraticIntersection_TestData.cpp View 1 chunk +0 lines, -98 lines 0 comments Download
D experimental/Intersection/QuadraticLineSegments.h View 1 chunk +0 lines, -12 lines 0 comments Download
D experimental/Intersection/QuadraticLineSegments.cpp View 1 chunk +0 lines, -34 lines 0 comments Download
D experimental/Intersection/QuadraticParameterization.h View 1 chunk +0 lines, -27 lines 0 comments Download
D experimental/Intersection/QuadraticParameterization.cpp View 1 chunk +0 lines, -135 lines 0 comments Download
D experimental/Intersection/QuadraticParameterization_Test.cpp View 1 chunk +0 lines, -48 lines 0 comments Download
D experimental/Intersection/QuadraticParameterization_TestUtility.cpp View 1 chunk +0 lines, -16 lines 0 comments Download
D experimental/Intersection/QuadraticReduceOrder.cpp View 1 chunk +0 lines, -184 lines 0 comments Download
D experimental/Intersection/QuadraticReduceOrder_Test.cpp View 1 chunk +0 lines, -67 lines 0 comments Download
D experimental/Intersection/QuadraticSubDivide.cpp View 1 chunk +0 lines, -79 lines 0 comments Download
D experimental/Intersection/QuadraticUtilities.h View 1 chunk +0 lines, -47 lines 0 comments Download
D experimental/Intersection/QuadraticUtilities.cpp View 1 chunk +0 lines, -255 lines 0 comments Download
D experimental/Intersection/QuarticRoot.h View 1 chunk +0 lines, -5 lines 0 comments Download
D experimental/Intersection/QuarticRoot.cpp View 1 chunk +0 lines, -236 lines 0 comments Download
D experimental/Intersection/QuarticRoot_Test.cpp View 1 chunk +0 lines, -195 lines 0 comments Download
D experimental/Intersection/ShapeOpCubic4x4_Test.cpp View 1 chunk +0 lines, -106 lines 0 comments Download
D experimental/Intersection/ShapeOpRect4x4_Test.cpp View 1 chunk +0 lines, -94 lines 0 comments Download
D experimental/Intersection/ShapeOps.h View 1 chunk +0 lines, -40 lines 0 comments Download
D experimental/Intersection/ShapeOps.cpp View 1 chunk +0 lines, -279 lines 0 comments Download
D experimental/Intersection/Simplify.h View 1 chunk +0 lines, -17 lines 0 comments Download
D experimental/Intersection/Simplify.cpp View 1 chunk +0 lines, -6608 lines 0 comments Download
D experimental/Intersection/SimplifyAddIntersectingTs_Test.cpp View 1 chunk +0 lines, -135 lines 0 comments Download
D experimental/Intersection/SimplifyAngle_Test.cpp View 1 chunk +0 lines, -342 lines 0 comments Download
D experimental/Intersection/SimplifyFindNext_Test.cpp View 1 chunk +0 lines, -153 lines 0 comments Download
D experimental/Intersection/SimplifyFindTop_Test.cpp View 1 chunk +0 lines, -222 lines 0 comments Download
D experimental/Intersection/SimplifyNew_Test.cpp View 1 chunk +0 lines, -5194 lines 0 comments Download
D experimental/Intersection/SimplifyRect4x4_Test.cpp View 1 chunk +0 lines, -200 lines 0 comments Download
D experimental/Intersection/SkAntiEdge.h View 1 chunk +0 lines, -76 lines 0 comments Download
D experimental/Intersection/SkAntiEdge.cpp View 1 chunk +0 lines, -1086 lines 0 comments Download
D experimental/Intersection/TSearch.h View 1 chunk +0 lines, -101 lines 0 comments Download
D experimental/Intersection/TestUtilities.h View 1 chunk +0 lines, -11 lines 0 comments Download
D experimental/Intersection/TestUtilities.cpp View 1 chunk +0 lines, -65 lines 0 comments Download
D experimental/Intersection/TriangleUtilities.h View 1 chunk +0 lines, -10 lines 0 comments Download
D experimental/Intersection/TriangleUtilities.cpp View 1 chunk +0 lines, -31 lines 0 comments Download
D experimental/Intersection/as.htm View 1 chunk +0 lines, -7027 lines 0 comments Download
D experimental/Intersection/bc.htm View 1 chunk +0 lines, -455 lines 0 comments Download
D experimental/Intersection/cd.htm View 1 chunk +0 lines, -517 lines 0 comments Download
D experimental/Intersection/edge_Prefix.pch View 1 chunk +0 lines, -5 lines 0 comments Download
D experimental/Intersection/hg.htm View 1 chunk +0 lines, -649 lines 0 comments Download
D experimental/Intersection/op.htm View 1 chunk +0 lines, -4806 lines 0 comments Download
D experimental/Intersection/qc.htm View 1 chunk +0 lines, -2883 lines 0 comments Download
D experimental/Intersection/thingsToDo.txt View 1 chunk +0 lines, -525 lines 0 comments Download
D gyp/pixman_test.gyp View 1 chunk +0 lines, -169 lines 0 comments Download
D gyp/shapeops_demo.gyp View 1 chunk +0 lines, -118 lines 0 comments Download
D gyp/shapeops_edge.gyp View 1 chunk +0 lines, -129 lines 0 comments Download
D gyp/shapeops_tool.gyp View 1 chunk +0 lines, -31 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/867213004/1
5 years, 10 months ago (2015-01-29 18:31:32 UTC) #3
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 10 months ago (2015-01-29 18:31:33 UTC) #4
reed1
lgtm
5 years, 10 months ago (2015-01-29 18:41:06 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-01-29 18:43:13 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/17a2b5473d0144d10749ef8d26a10fbdab580226

Powered by Google App Engine
This is Rietveld 408576698