Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 671663002: Standardize usage of virtual/override/final in content/ (Closed)

Created:
6 years, 2 months ago by dcheng
Modified:
6 years, 2 months ago
Reviewers:
Avi (use Gerrit)
CC:
Aaron Boodman, aandrey+blink_chromium.org, abarth-chromium, avayvod+watch_chromium.org, ben+mojo_chromium.org, cbentzel+watch_chromium.org, chromium-reviews, cmumford, danakj+watch_chromium.org, darin (slow to review), darin-cc_chromium.org, devtools-reviews_chromium.org, dgrogan, feature-media-reviews_chromium.org, hclam+watch_chromium.org, hguihot+watch_chromium.org, horo+watch_chromium.org, hubbe+watch_chromium.org, imcheng+watch_chromium.org, jam, jasonroberts+watch_google.com, jbauman+watch_chromium.org, jdduke+watch_chromium.org, jochen+watch_chromium.org, jsbell+idb_chromium.org, jsbell+serviceworker_chromium.org, kalyank, kinuko+fileapi, kinuko+serviceworker, mcasas+watch_chromium.org, michaeln, mikhal+watch_chromium.org, miu+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, mkwst+moarreviews-ipc_chromium.org, Michael van Ouwerkerk, nhiroki, paulirish+reviews_chromium.org, pfeldman, piman+watch_chromium.org, posciak+watch_chromium.org, pwestin+watch_google.com, qsr+mojo_chromium.org, serviceworker-reviews, sievers+watch_chromium.org, tzik, viettrungluu+watch_chromium.org, vsevik, wjia+watch_chromium.org, yurys, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Standardize usage of virtual/override/final in content/ This patch was automatically generated by applying clang fixit hints generated by the plugin to the source tree. BUG=417463 TBR=avi@chromium.org Committed: https://crrev.com/e933b3eb38cf13b7b96141214fa266cf499459ff Cr-Commit-Position: refs/heads/master@{#300461}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2132 lines, -2233 lines) Patch
M content/app/content_main_runner.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/child/appcache/appcache_backend_proxy.h View 1 chunk +18 lines, -22 lines 0 comments Download
M content/child/appcache/appcache_dispatcher.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/child/appcache/appcache_frontend_impl.h View 1 chunk +15 lines, -17 lines 0 comments Download
M content/child/blink_platform_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/child/blink_platform_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/browser_font_resource_trusted.h View 1 chunk +16 lines, -19 lines 0 comments Download
M content/child/child_gpu_memory_buffer_manager.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/child/child_histogram_message_filter.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/child/child_message_filter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/child/child_message_filter.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/child/child_resource_message_filter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/child/child_shared_bitmap_manager.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/child/child_thread.h View 2 chunks +6 lines, -6 lines 0 comments Download
M content/child/child_thread.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/child/db_message_filter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/child/fileapi/file_system_dispatcher.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/child/fileapi/webfilesystem_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/child/fileapi/webfilewriter_base_unittest.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M content/child/fileapi/webfilewriter_impl.h View 1 chunk +5 lines, -4 lines 0 comments Download
M content/child/geofencing/geofencing_dispatcher.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/child/geofencing/geofencing_message_filter.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/child/indexed_db/indexed_db_dispatcher.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/child/indexed_db/indexed_db_dispatcher_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/child/indexed_db/indexed_db_message_filter.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/child/indexed_db/webidbcursor_impl_unittest.cc View 1 chunk +16 lines, -16 lines 0 comments Download
M content/child/npapi/np_channel_base.h View 3 chunks +5 lines, -5 lines 0 comments Download
M content/child/npapi/npobject_proxy.h View 4 chunks +6 lines, -6 lines 0 comments Download
M content/child/npapi/npobject_stub.h View 2 chunks +6 lines, -6 lines 0 comments Download
M content/child/npapi/plugin_lib_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/npapi/plugin_stream_url.h View 1 chunk +16 lines, -18 lines 0 comments Download
M content/child/npapi/plugin_string_stream.h View 1 chunk +1 line, -1 line 0 comments Download
M content/child/npapi/plugin_url_fetcher.h View 2 chunks +15 lines, -15 lines 0 comments Download
M content/child/npapi/webplugin_delegate_impl.h View 2 chunks +50 lines, -48 lines 0 comments Download
M content/child/power_monitor_broadcast_source.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/child/power_monitor_broadcast_source.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/child/quota_dispatcher.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/child/quota_dispatcher.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M content/child/quota_message_filter.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/child/resource_dispatcher.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/child/resource_dispatcher.cc View 1 chunk +9 lines, -9 lines 0 comments Download
M content/child/resource_dispatcher_unittest.cc View 4 chunks +30 lines, -37 lines 0 comments Download
M content/child/service_worker/service_worker_dispatcher.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/child/service_worker/service_worker_message_filter.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/child/service_worker/service_worker_network_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M content/child/site_isolation_policy_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/socket_stream_dispatcher.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/child/socket_stream_dispatcher.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/child/thread_safe_sender.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/child/threaded_data_provider.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/child/web_socket_stream_handle_impl.cc View 1 chunk +6 lines, -10 lines 0 comments Download
M content/child/web_url_loader_impl.cc View 1 chunk +16 lines, -17 lines 0 comments Download
M content/child/web_url_loader_impl_unittest.cc View 2 chunks +11 lines, -12 lines 0 comments Download
M content/child/webcrypto/openssl/aes_cbc_openssl.cc View 1 chunk +8 lines, -8 lines 0 comments Download
M content/child/webcrypto/openssl/aes_ctr_openssl.cc View 1 chunk +8 lines, -8 lines 0 comments Download
M content/child/webcrypto/openssl/aes_gcm_openssl.cc View 1 chunk +8 lines, -8 lines 0 comments Download
M content/child/webcrypto/openssl/aes_key_openssl.h View 1 chunk +19 lines, -19 lines 0 comments Download
M content/child/webcrypto/openssl/aes_kw_openssl.cc View 1 chunk +8 lines, -8 lines 0 comments Download
M content/child/webcrypto/openssl/hmac_openssl.cc View 7 chunks +28 lines, -28 lines 0 comments Download
M content/child/webcrypto/openssl/key_openssl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/child/webcrypto/openssl/rsa_key_openssl.h View 1 chunk +26 lines, -26 lines 0 comments Download
M content/child/webcrypto/openssl/rsa_oaep_openssl.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M content/child/webcrypto/openssl/rsa_pss_openssl.cc View 2 chunks +10 lines, -10 lines 0 comments Download
M content/child/webcrypto/openssl/rsa_ssa_openssl.cc View 2 chunks +10 lines, -10 lines 0 comments Download
M content/child/webcrypto/openssl/sha_openssl.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/child/webmessageportchannel_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/child/websocket_dispatcher.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/child/webthread_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/child/worker_thread_task_runner.h View 1 chunk +5 lines, -5 lines 0 comments Download
M content/common/child_process_host_impl.h View 3 chunks +11 lines, -11 lines 0 comments Download
M content/common/gpu/client/command_buffer_proxy_impl.h View 3 chunks +32 lines, -33 lines 0 comments Download
M content/common/gpu/client/context_provider_command_buffer.h View 2 chunks +13 lines, -13 lines 0 comments Download
M content/common/gpu/client/gl_helper.cc View 2 chunks +10 lines, -12 lines 0 comments Download
M content/common/gpu/client/gl_helper_scaling.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M content/common/gpu/client/gpu_channel_host.h View 4 chunks +5 lines, -5 lines 0 comments Download
M content/common/gpu/client/gpu_memory_buffer_impl.h View 2 chunks +4 lines, -4 lines 0 comments Download
M content/common/gpu/client/gpu_memory_buffer_impl_io_surface.h View 1 chunk +5 lines, -5 lines 0 comments Download
M content/common/gpu/client/gpu_memory_buffer_impl_ozone_native_buffer.h View 1 chunk +5 lines, -5 lines 0 comments Download
M content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.h View 1 chunk +5 lines, -5 lines 0 comments Download
M content/common/gpu/client/gpu_video_decode_accelerator_host.h View 1 chunk +11 lines, -12 lines 0 comments Download
M content/common/gpu/client/gpu_video_encode_accelerator_host.h View 1 chunk +16 lines, -17 lines 0 comments Download
M content/common/gpu/gpu_channel.h View 2 chunks +4 lines, -4 lines 0 comments Download
M content/common/gpu/gpu_channel.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/common/gpu/gpu_channel_manager.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/common/gpu/gpu_channel_manager.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/common/gpu/gpu_command_buffer_stub.h View 1 chunk +8 lines, -9 lines 0 comments Download
M content/common/gpu/gpu_command_buffer_stub.cc View 4 chunks +5 lines, -6 lines 0 comments Download
M content/common/gpu/gpu_memory_buffer_factory_mac.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/common/gpu/gpu_memory_manager_unittest.cc View 3 chunks +10 lines, -14 lines 0 comments Download
M content/common/gpu/image_transport_surface.h View 2 chunks +13 lines, -13 lines 0 comments Download
M content/common/gpu/image_transport_surface_calayer_mac.h View 1 chunk +11 lines, -10 lines 0 comments Download
M content/common/gpu/image_transport_surface_fbo_mac.h View 2 chunks +20 lines, -21 lines 0 comments Download
M content/common/gpu/image_transport_surface_iosurface_mac.h View 1 chunk +11 lines, -10 lines 0 comments Download
M content/common/gpu/image_transport_surface_mac.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/gpu/media/gpu_video_decode_accelerator.h View 2 chunks +13 lines, -13 lines 0 comments Download
M content/common/gpu/media/gpu_video_decode_accelerator.cc View 2 chunks +6 lines, -8 lines 0 comments Download
M content/common/gpu/media/gpu_video_encode_accelerator.h View 2 chunks +10 lines, -10 lines 0 comments Download
M content/common/gpu/media/vt_video_decode_accelerator.h View 1 chunk +9 lines, -11 lines 0 comments Download
M content/common/gpu/null_transport_surface.h View 1 chunk +7 lines, -7 lines 0 comments Download
M content/common/host_shared_bitmap_manager.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/common/input/synthetic_pinch_gesture_params.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/input/synthetic_smooth_scroll_gesture_params.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/input/synthetic_tap_gesture_params.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/message_router.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/common/mojo/service_registry_impl.h View 2 chunks +10 lines, -13 lines 0 comments Download
M content/common/net/url_request_user_data.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/one_writer_seqlock_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/resource_request_body.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/sandbox_mac_fontloading_unittest.mm View 1 chunk +3 lines, -2 lines 0 comments Download
M content/common/sandbox_mac_system_access_unittest.mm View 4 chunks +7 lines, -6 lines 0 comments Download
M content/common/socket_stream_handle_data.h View 1 chunk +1 line, -1 line 0 comments Download
M content/gpu/gpu_child_thread.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/gpu/gpu_process.h View 1 chunk +1 line, -1 line 0 comments Download
M content/gpu/gpu_watchdog_thread.h View 3 chunks +9 lines, -10 lines 0 comments Download
M content/gpu/in_process_gpu_thread.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/plugin/plugin_channel.h View 3 chunks +11 lines, -11 lines 0 comments Download
M content/plugin/plugin_channel.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M content/plugin/plugin_thread.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/plugin/plugin_thread.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/plugin/webplugin_accelerated_surface_proxy_mac.h View 1 chunk +5 lines, -5 lines 0 comments Download
M content/plugin/webplugin_delegate_stub.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/plugin/webplugin_proxy.h View 1 chunk +44 lines, -46 lines 0 comments Download
M content/ppapi_plugin/broker_process_dispatcher.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/ppapi_plugin/plugin_process_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M content/ppapi_plugin/ppapi_thread.h View 2 chunks +19 lines, -21 lines 0 comments Download
M content/public/browser/browser_child_process_host.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/browser_child_process_host_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/browser_context.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/browser_message_filter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/browser/browser_message_filter.cc View 2 chunks +7 lines, -9 lines 0 comments Download
M content/public/browser/download_item.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/download_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/render_frame_host.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/render_process_host.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/render_view_host.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/render_widget_host.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/resource_context.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/resource_request_details.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/screen_orientation_provider.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/browser/utility_process_host.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/web_contents.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/web_contents_observer.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/public/common/child_process_host.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/child_process_host_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/renderer/media_stream_audio_sink.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/renderer/media_stream_video_sink.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/renderer/render_frame.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/renderer/render_frame_observer.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/public/renderer/render_thread.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/renderer/render_view.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/renderer/render_view_observer.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/public/renderer/renderer_gamepad_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/browser_test.h View 1 chunk +60 lines, -50 lines 0 comments Download
M content/public/test/browser_test_base.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M content/public/test/browser_test_utils.h View 6 chunks +14 lines, -14 lines 0 comments Download
M content/public/test/browser_test_utils.cc View 3 chunks +7 lines, -11 lines 0 comments Download
M content/public/test/content_browser_test.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/content_browser_test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/content_test_suite_base.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/download_test_observer.h View 8 chunks +18 lines, -21 lines 0 comments Download
M content/public/test/fake_speech_recognition_manager.h View 2 chunks +16 lines, -17 lines 0 comments Download
M content/public/test/frame_load_waiter.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/javascript_test_observer.h View 2 chunks +4 lines, -5 lines 0 comments Download
M content/public/test/mock_blob_url_request_context.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/mock_render_process_host.h View 3 chunks +47 lines, -49 lines 0 comments Download
M content/public/test/mock_render_thread.h View 1 chunk +29 lines, -30 lines 0 comments Download
M content/public/test/mock_resource_context.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/public/test/mock_special_storage_policy.h View 2 chunks +8 lines, -8 lines 0 comments Download
M content/public/test/mock_storage_client.h View 2 chunks +15 lines, -14 lines 0 comments Download
M content/public/test/test_browser_context.h View 2 chunks +16 lines, -17 lines 0 comments Download
M content/public/test/test_browser_context.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M content/public/test/test_browser_thread.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M content/public/test/test_file_error_injector.cc View 2 chunks +10 lines, -12 lines 0 comments Download
M content/public/test/test_file_system_backend.h View 1 chunk +20 lines, -21 lines 0 comments Download
M content/public/test/test_file_system_backend.cc View 6 chunks +27 lines, -31 lines 0 comments Download
M content/public/test/test_launcher.cc View 1 chunk +6 lines, -7 lines 0 comments Download
M content/public/test/test_navigation_observer.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M content/public/test/test_notification_tracker.h View 2 chunks +5 lines, -4 lines 0 comments Download
M content/public/test/test_utils.h View 3 chunks +7 lines, -8 lines 0 comments Download
M content/public/test/test_utils.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M content/public/utility/utility_thread.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/app/shell_crash_reporter_client.h View 2 chunks +3 lines, -4 lines 0 comments Download
M content/shell/app/shell_main_delegate.h View 1 chunk +7 lines, -8 lines 0 comments Download
M content/shell/browser/ipc_echo_message_filter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_browser_context.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_browser_main_parts.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_content_browser_client.h View 1 chunk +9 lines, -9 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_devtools_frontend.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_download_manager_delegate.h View 1 chunk +3 lines, -4 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_javascript_dialog_manager.h View 1 chunk +14 lines, -16 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_message_filter.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_resource_dispatcher_host_delegate.h View 1 chunk +4 lines, -3 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_url_request_context_getter.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/shell/browser/notify_done_forwarder.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/shell/browser/shell.h View 3 chunks +35 lines, -38 lines 0 comments Download
M content/shell/browser/shell.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/shell_browser_context.h View 3 chunks +19 lines, -20 lines 0 comments Download
M content/shell/browser/shell_browser_main_parts.h View 1 chunk +7 lines, -7 lines 0 comments Download
M content/shell/browser/shell_content_browser_client.h View 1 chunk +23 lines, -23 lines 0 comments Download
M content/shell/browser/shell_devtools_delegate.h View 2 chunks +15 lines, -16 lines 0 comments Download
M content/shell/browser/shell_devtools_delegate.cc View 3 chunks +13 lines, -17 lines 0 comments Download
M content/shell/browser/shell_devtools_frontend.h View 1 chunk +9 lines, -11 lines 0 comments Download
M content/shell/browser/shell_download_manager_delegate.h View 1 chunk +7 lines, -9 lines 0 comments Download
M content/shell/browser/shell_javascript_dialog_manager.h View 1 chunk +18 lines, -21 lines 0 comments Download
M content/shell/browser/shell_login_dialog.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/browser/shell_net_log.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/shell_network_delegate.h View 1 chunk +27 lines, -30 lines 0 comments Download
M content/shell/browser/shell_plugin_service_filter.h View 1 chunk +10 lines, -10 lines 0 comments Download
M content/shell/browser/shell_quota_permission_context.h View 1 chunk +4 lines, -5 lines 0 comments Download
M content/shell/browser/shell_resource_dispatcher_host_delegate.h View 1 chunk +4 lines, -3 lines 0 comments Download
M content/shell/browser/shell_speech_recognition_manager_delegate.h View 1 chunk +7 lines, -6 lines 0 comments Download
M content/shell/browser/shell_url_request_context_getter.h View 1 chunk +4 lines, -5 lines 0 comments Download
M content/shell/browser/shell_web_contents_view_delegate.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/shell/browser/webkit_test_controller.h View 2 chunks +11 lines, -11 lines 0 comments Download
M content/shell/common/shell_content_client.h View 1 chunk +6 lines, -6 lines 0 comments Download
M content/shell/geolocation/shell_access_token_store.h View 1 chunk +4 lines, -5 lines 0 comments Download
M content/shell/renderer/ipc_echo.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/shell/renderer/layout_test/gc_controller.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/shell/renderer/layout_test/layout_test_content_renderer_client.h View 1 chunk +10 lines, -12 lines 0 comments Download
M content/shell/renderer/layout_test/layout_test_render_frame_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/renderer/layout_test/layout_test_render_process_observer.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/shell/renderer/layout_test/webkit_test_runner.h View 1 chunk +60 lines, -65 lines 0 comments Download
M content/shell/renderer/layout_test/webkit_test_runner.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M content/shell/renderer/shell_content_renderer_client.h View 1 chunk +6 lines, -6 lines 0 comments Download
M content/shell/renderer/shell_render_view_observer.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/shell/renderer/test_runner/accessibility_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/shell/renderer/test_runner/event_sender.cc View 4 chunks +5 lines, -9 lines 0 comments Download
M content/shell/renderer/test_runner/gamepad_controller.h View 1 chunk +5 lines, -6 lines 0 comments Download
M content/shell/renderer/test_runner/gamepad_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/shell/renderer/test_runner/mock_color_chooser.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/renderer/test_runner/mock_web_media_stream_center.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/shell/renderer/test_runner/mock_web_midi_accessor.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/renderer/test_runner/mock_web_speech_recognizer.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/renderer/test_runner/mock_web_speech_recognizer.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M content/shell/renderer/test_runner/mock_web_user_media_client.cc View 5 chunks +5 lines, -7 lines 0 comments Download
M content/shell/renderer/test_runner/mock_webrtc_data_channel_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/renderer/test_runner/mock_webrtc_dtmf_sender_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/renderer/test_runner/mock_webrtc_peer_connection_handler.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M content/shell/renderer/test_runner/spell_check_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/shell/renderer/test_runner/test_plugin.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/renderer/test_runner/test_runner.h View 2 chunks +6 lines, -7 lines 0 comments Download
M content/shell/renderer/test_runner/test_runner.cc View 9 chunks +10 lines, -10 lines 0 comments Download
M content/shell/renderer/test_runner/text_input_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/shell/renderer/test_runner/web_ax_object_proxy.h View 3 chunks +6 lines, -7 lines 0 comments Download
M content/shell/renderer/test_runner/web_test_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/tools/plugin/Tests/DocumentOpenInDestroyStream.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M content/shell/tools/plugin/Tests/EvaluateJSAfterRemovingPluginElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/tools/plugin/Tests/FormValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/tools/plugin/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp View 1 chunk +9 lines, -8 lines 0 comments Download
M content/shell/tools/plugin/Tests/GetURLWithJavaScriptURL.cpp View 3 chunks +16 lines, -14 lines 0 comments Download
M content/shell/tools/plugin/Tests/GetURLWithJavaScriptURLDestroyingPlugin.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M content/shell/tools/plugin/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M content/shell/tools/plugin/Tests/LeakWindowScriptableObject.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M content/shell/tools/plugin/Tests/LogNPPSetWindow.cpp View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/tools/plugin/Tests/NPDeallocateCalledBeforeNPShutdown.cpp View 2 chunks +8 lines, -10 lines 0 comments Download
M content/shell/tools/plugin/Tests/NPPNewFails.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M content/shell/tools/plugin/Tests/NPRuntimeCallsWithNullNPP.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M content/shell/tools/plugin/Tests/NPRuntimeObjectFromDestroyedPlugin.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M content/shell/tools/plugin/Tests/NPRuntimeRemoveProperty.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M content/shell/tools/plugin/Tests/NullNPPGetValuePointer.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M content/shell/tools/plugin/Tests/PassDifferentNPPStruct.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M content/shell/tools/plugin/Tests/PluginScriptableNPObjectInvokeDefault.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M content/shell/tools/plugin/Tests/PluginScriptableObjectOverridesAllProperties.cpp View 2 chunks +2 lines, -5 lines 0 comments Download
M content/test/appcache_test_helper.h View 1 chunk +5 lines, -6 lines 0 comments Download
M content/test/browser_test_utils_browsertest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/test/content_browser_test_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/test/content_test_launcher.cc View 3 chunks +8 lines, -9 lines 0 comments Download
M content/test/content_test_suite.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/mock_google_streaming_server.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/test/mock_render_process.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/test/net/url_request_abort_on_end_job.h View 1 chunk +5 lines, -7 lines 0 comments Download
M content/test/net/url_request_slow_download_job.h View 2 chunks +5 lines, -7 lines 0 comments Download
M content/test/plugin/plugin_arguments_test.h View 1 chunk +6 lines, -3 lines 0 comments Download
M content/test/plugin/plugin_delete_plugin_in_deallocate_test.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/plugin/plugin_delete_plugin_in_stream_test.h View 1 chunk +6 lines, -3 lines 0 comments Download
M content/test/plugin/plugin_execute_stream_javascript.h View 1 chunk +7 lines, -6 lines 0 comments Download
M content/test/plugin/plugin_get_javascript_url2_test.h View 1 chunk +9 lines, -10 lines 0 comments Download
M content/test/plugin/plugin_get_javascript_url_test.h View 1 chunk +9 lines, -10 lines 0 comments Download
M content/test/plugin/plugin_geturl_test.h View 1 chunk +19 lines, -15 lines 0 comments Download
M content/test/plugin/plugin_javascript_open_popup.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/test/plugin/plugin_new_fails_test.h View 1 chunk +5 lines, -2 lines 0 comments Download
M content/test/plugin/plugin_npobject_identity_test.h View 1 chunk +1 line, -1 line 0 comments Download
M content/test/plugin/plugin_npobject_lifetime_test.h View 3 chunks +7 lines, -8 lines 0 comments Download
M content/test/plugin/plugin_npobject_proxy_test.h View 1 chunk +1 line, -1 line 0 comments Download
M content/test/plugin/plugin_private_test.h View 1 chunk +5 lines, -2 lines 0 comments Download
M content/test/plugin/plugin_request_read_test.h View 1 chunk +14 lines, -10 lines 0 comments Download
M content/test/plugin/plugin_schedule_timer_test.h View 1 chunk +5 lines, -2 lines 0 comments Download
M content/test/plugin/plugin_setup_test.h View 1 chunk +1 line, -1 line 0 comments Download
M content/test/plugin/plugin_thread_async_call_test.h View 1 chunk +7 lines, -4 lines 0 comments Download
M content/test/plugin/plugin_window_size_test.h View 1 chunk +1 line, -1 line 0 comments Download
M content/test/plugin/plugin_windowless_test.h View 1 chunk +7 lines, -4 lines 0 comments Download
M content/test/test_content_browser_client.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/test_content_client.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/test/test_frame_navigation_observer.h View 2 chunks +8 lines, -10 lines 0 comments Download
M content/test/test_media_stream_renderer_factory.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/test/test_render_frame_host.h View 2 chunks +13 lines, -15 lines 0 comments Download
M content/test/test_render_frame_host_factory.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/test_render_view_host.h View 3 chunks +71 lines, -74 lines 0 comments Download
M content/test/test_render_view_host_factory.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/test_video_frame_provider.h View 1 chunk +5 lines, -5 lines 0 comments Download
M content/test/test_web_contents.h View 4 chunks +39 lines, -44 lines 0 comments Download
M content/test/web_layer_tree_view_impl_for_testing.h View 1 chunk +19 lines, -19 lines 0 comments Download
M content/test/webrtc_content_browsertest_base.h View 1 chunk +1 line, -1 line 0 comments Download
M content/utility/in_process_utility_thread.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/utility/utility_thread_impl.h View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
dcheng
6 years, 2 months ago (2014-10-21 10:24:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/671663002/1
6 years, 2 months ago (2014-10-21 10:26:30 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-21 11:44:29 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e933b3eb38cf13b7b96141214fa266cf499459ff Cr-Commit-Position: refs/heads/master@{#300461}
6 years, 2 months ago (2014-10-21 11:45:10 UTC) #5
Avi (use Gerrit)
6 years, 2 months ago (2014-10-21 14:47:43 UTC) #6
Message was sent while issue was closed. 
lgtm

Stampity stamp

Powered by Google App Engine
This is Rietveld 408576698