content/shell/renderer/layout_test/layout_test_content_renderer_client.h - Issue 671663002: Standardize usage of virtual/override/final in content/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/renderer/layout_test/layout_test_content_renderer_client.h

Issue 671663002: Standardize usage of virtual/override/final in content/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/shell/renderer/layout_test/gc_controller.h ('k') | content/shell/renderer/layout_test/layout_test_render_frame_observer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/renderer/layout_test/layout_test_content_renderer_client.h

diff --git a/content/shell/renderer/layout_test/layout_test_content_renderer_client.h b/content/shell/renderer/layout_test/layout_test_content_renderer_client.h

index 1b786d2e2698bd937c39f4cd7a39f345eb90c835..c3a2605ce19154433d44c06594d4c03a7820d149 100644

--- a/content/shell/renderer/layout_test/layout_test_content_renderer_client.h

+++ b/content/shell/renderer/layout_test/layout_test_content_renderer_client.h

@@ -28,23 +28,21 @@ class WebTestProxyBase;

class LayoutTestContentRendererClient : public ShellContentRendererClient {

public:

LayoutTestContentRendererClient();

- virtual ~LayoutTestContentRendererClient();

+ ~LayoutTestContentRendererClient() override;

// ShellContentRendererClient implementation.

- virtual void RenderThreadStarted() override;

- virtual void RenderFrameCreated(RenderFrame* render_frame) override;

- virtual void RenderViewCreated(RenderView* render_view) override;

- virtual blink::WebMediaStreamCenter* OverrideCreateWebMediaStreamCenter(

+ void RenderThreadStarted() override;

+ void RenderFrameCreated(RenderFrame* render_frame) override;

+ void RenderViewCreated(RenderView* render_view) override;

+ blink::WebMediaStreamCenter* OverrideCreateWebMediaStreamCenter(

blink::WebMediaStreamCenterClient* client) override;

- virtual blink::WebRTCPeerConnectionHandler*

- OverrideCreateWebRTCPeerConnectionHandler(

+ blink::WebRTCPeerConnectionHandler* OverrideCreateWebRTCPeerConnectionHandler(

blink::WebRTCPeerConnectionHandlerClient* client) override;

- virtual blink::WebMIDIAccessor* OverrideCreateMIDIAccessor(

+ blink::WebMIDIAccessor* OverrideCreateMIDIAccessor(

blink::WebMIDIAccessorClient* client) override;

- virtual blink::WebAudioDevice* OverrideCreateAudioDevice(

- double sample_rate) override;

- virtual blink::WebClipboard* OverrideWebClipboard() override;

- virtual blink::WebThemeEngine* OverrideThemeEngine() override;

+ blink::WebAudioDevice* OverrideCreateAudioDevice(double sample_rate) override;

+ blink::WebClipboard* OverrideWebClipboard() override;

+ blink::WebThemeEngine* OverrideThemeEngine() override;

private:

void WebTestProxyCreated(RenderView* render_view, WebTestProxyBase* proxy);