Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2217)

Unified Diff: content/shell/browser/shell.h

Issue 671663002: Standardize usage of virtual/override/final in content/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/shell/browser/notify_done_forwarder.h ('k') | content/shell/browser/shell.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/shell/browser/shell.h
diff --git a/content/shell/browser/shell.h b/content/shell/browser/shell.h
index 883ff0c6ed85219ac9f59e35c559e4f67fa09a8a..ee08bcff3998e73a273fc11fde9ded7033c0b37b 100644
--- a/content/shell/browser/shell.h
+++ b/content/shell/browser/shell.h
@@ -56,7 +56,7 @@ class Shell : public WebContentsDelegate,
static const int kDefaultTestWindowWidthDip;
static const int kDefaultTestWindowHeightDip;
- virtual ~Shell();
+ ~Shell() override;
void LoadURL(const GURL& url);
void LoadURLForFrame(const GURL& url, const std::string& frame_name);
@@ -113,49 +113,46 @@ class Shell : public WebContentsDelegate,
#endif
// WebContentsDelegate
- virtual WebContents* OpenURLFromTab(WebContents* source,
- const OpenURLParams& params) override;
- virtual void AddNewContents(WebContents* source,
- WebContents* new_contents,
- WindowOpenDisposition disposition,
- const gfx::Rect& initial_pos,
- bool user_gesture,
- bool* was_blocked) override;
- virtual void LoadingStateChanged(WebContents* source,
- bool to_different_document) override;
+ WebContents* OpenURLFromTab(WebContents* source,
+ const OpenURLParams& params) override;
+ void AddNewContents(WebContents* source,
+ WebContents* new_contents,
+ WindowOpenDisposition disposition,
+ const gfx::Rect& initial_pos,
+ bool user_gesture,
+ bool* was_blocked) override;
+ void LoadingStateChanged(WebContents* source,
+ bool to_different_document) override;
#if defined(OS_ANDROID)
virtual void LoadProgressChanged(WebContents* source,
double progress) override;
#endif
- virtual void ToggleFullscreenModeForTab(WebContents* web_contents,
- bool enter_fullscreen) override;
- virtual bool IsFullscreenForTabOrPending(
+ void ToggleFullscreenModeForTab(WebContents* web_contents,
+ bool enter_fullscreen) override;
+ bool IsFullscreenForTabOrPending(
const WebContents* web_contents) const override;
- virtual void RequestToLockMouse(WebContents* web_contents,
- bool user_gesture,
- bool last_unlocked_by_target) override;
- virtual void CloseContents(WebContents* source) override;
- virtual bool CanOverscrollContent() const override;
- virtual void DidNavigateMainFramePostCommit(
- WebContents* web_contents) override;
- virtual JavaScriptDialogManager* GetJavaScriptDialogManager() override;
+ void RequestToLockMouse(WebContents* web_contents,
+ bool user_gesture,
+ bool last_unlocked_by_target) override;
+ void CloseContents(WebContents* source) override;
+ bool CanOverscrollContent() const override;
+ void DidNavigateMainFramePostCommit(WebContents* web_contents) override;
+ JavaScriptDialogManager* GetJavaScriptDialogManager() override;
#if defined(OS_MACOSX)
- virtual void HandleKeyboardEvent(
- WebContents* source,
- const NativeWebKeyboardEvent& event) override;
+ void HandleKeyboardEvent(WebContents* source,
+ const NativeWebKeyboardEvent& event) override;
#endif
- virtual bool AddMessageToConsole(WebContents* source,
- int32 level,
- const base::string16& message,
- int32 line_no,
- const base::string16& source_id) override;
- virtual void RendererUnresponsive(WebContents* source) override;
- virtual void ActivateContents(WebContents* contents) override;
- virtual void DeactivateContents(WebContents* contents) override;
- virtual void WorkerCrashed(WebContents* source) override;
- virtual bool HandleContextMenu(const content::ContextMenuParams& params)
- override;
- virtual void WebContentsFocused(WebContents* contents) override;
+ bool AddMessageToConsole(WebContents* source,
+ int32 level,
+ const base::string16& message,
+ int32 line_no,
+ const base::string16& source_id) override;
+ void RendererUnresponsive(WebContents* source) override;
+ void ActivateContents(WebContents* contents) override;
+ void DeactivateContents(WebContents* contents) override;
+ void WorkerCrashed(WebContents* source) override;
+ bool HandleContextMenu(const content::ContextMenuParams& params) override;
+ void WebContentsFocused(WebContents* contents) override;
private:
enum UIControl {
@@ -214,7 +211,7 @@ class Shell : public WebContentsDelegate,
gfx::NativeView GetContentView();
// WebContentsObserver
- virtual void TitleWasSet(NavigationEntry* entry, bool explicit_set) override;
+ void TitleWasSet(NavigationEntry* entry, bool explicit_set) override;
void InnerShowDevTools(const std::string& settings,
const std::string& frontend_url);
« no previous file with comments | « content/shell/browser/notify_done_forwarder.h ('k') | content/shell/browser/shell.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698