Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Side by Side Diff: content/child/web_url_loader_impl_unittest.cc

Issue 671663002: Standardize usage of virtual/override/final in content/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/child/web_url_loader_impl.h" 5 #include "content/child/web_url_loader_impl.h"
6 6
7 #include <string.h> 7 #include <string.h>
8 8
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/macros.h" 10 #include "base/macros.h"
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
61 61
62 class TestBridge : public ResourceLoaderBridge, 62 class TestBridge : public ResourceLoaderBridge,
63 public base::SupportsWeakPtr<TestBridge> { 63 public base::SupportsWeakPtr<TestBridge> {
64 public: 64 public:
65 TestBridge(const RequestInfo& info) : 65 TestBridge(const RequestInfo& info) :
66 peer_(NULL), 66 peer_(NULL),
67 canceled_(false), 67 canceled_(false),
68 url_(info.url) { 68 url_(info.url) {
69 } 69 }
70 70
71 virtual ~TestBridge() {} 71 ~TestBridge() override {}
72 72
73 // ResourceLoaderBridge implementation: 73 // ResourceLoaderBridge implementation:
74 virtual void SetRequestBody(ResourceRequestBody* request_body) override {} 74 void SetRequestBody(ResourceRequestBody* request_body) override {}
75 75
76 virtual bool Start(RequestPeer* peer) override { 76 bool Start(RequestPeer* peer) override {
77 EXPECT_FALSE(peer_); 77 EXPECT_FALSE(peer_);
78 peer_ = peer; 78 peer_ = peer;
79 return true; 79 return true;
80 } 80 }
81 81
82 virtual void Cancel() override { 82 void Cancel() override {
83 EXPECT_FALSE(canceled_); 83 EXPECT_FALSE(canceled_);
84 canceled_ = true; 84 canceled_ = true;
85 } 85 }
86 86
87 virtual void SetDefersLoading(bool value) override {} 87 void SetDefersLoading(bool value) override {}
88 88
89 virtual void DidChangePriority(net::RequestPriority new_priority, 89 void DidChangePriority(net::RequestPriority new_priority,
90 int intra_priority_value) override {} 90 int intra_priority_value) override {}
91 91
92 virtual bool AttachThreadedDataReceiver( 92 bool AttachThreadedDataReceiver(
93 blink::WebThreadedDataReceiver* threaded_data_receiver) override { 93 blink::WebThreadedDataReceiver* threaded_data_receiver) override {
94 NOTREACHED(); 94 NOTREACHED();
95 return false; 95 return false;
96 } 96 }
97 97
98 virtual void SyncLoad(SyncLoadResponse* response) override {} 98 void SyncLoad(SyncLoadResponse* response) override {}
99 99
100 RequestPeer* peer() { return peer_; } 100 RequestPeer* peer() { return peer_; }
101 101
102 bool canceled() { return canceled_; } 102 bool canceled() { return canceled_; }
103 103
104 const GURL& url() { return url_; } 104 const GURL& url() { return url_; }
105 105
106 private: 106 private:
107 RequestPeer* peer_; 107 RequestPeer* peer_;
108 bool canceled_; 108 bool canceled_;
109 GURL url_; 109 GURL url_;
110 110
111 DISALLOW_COPY_AND_ASSIGN(TestBridge); 111 DISALLOW_COPY_AND_ASSIGN(TestBridge);
112 }; 112 };
113 113
114 class TestResourceDispatcher : public ResourceDispatcher { 114 class TestResourceDispatcher : public ResourceDispatcher {
115 public: 115 public:
116 TestResourceDispatcher() : ResourceDispatcher(NULL) {} 116 TestResourceDispatcher() : ResourceDispatcher(NULL) {}
117 virtual ~TestResourceDispatcher() {} 117 ~TestResourceDispatcher() override {}
118 118
119 // ResourceDispatcher implementation: 119 // ResourceDispatcher implementation:
120 virtual ResourceLoaderBridge* CreateBridge( 120 ResourceLoaderBridge* CreateBridge(const RequestInfo& request_info) override {
121 const RequestInfo& request_info) override {
122 EXPECT_FALSE(bridge_.get()); 121 EXPECT_FALSE(bridge_.get());
123 TestBridge* bridge = new TestBridge(request_info); 122 TestBridge* bridge = new TestBridge(request_info);
124 bridge_ = bridge->AsWeakPtr(); 123 bridge_ = bridge->AsWeakPtr();
125 return bridge; 124 return bridge;
126 } 125 }
127 126
128 TestBridge* bridge() { return bridge_.get(); } 127 TestBridge* bridge() { return bridge_.get(); }
129 128
130 private: 129 private:
131 base::WeakPtr<TestBridge> bridge_; 130 base::WeakPtr<TestBridge> bridge_;
(...skipping 567 matching lines...) Expand 10 before | Expand all | Expand 10 after
699 EXPECT_EQ(kMimeType, client()->response().mimeType().latin1()); 698 EXPECT_EQ(kMimeType, client()->response().mimeType().latin1());
700 699
701 DoReceiveData(); 700 DoReceiveData();
702 DoCompleteRequest(); 701 DoCompleteRequest();
703 EXPECT_FALSE(bridge()->canceled()); 702 EXPECT_FALSE(bridge()->canceled());
704 EXPECT_EQ(kTestData, client()->received_data()); 703 EXPECT_EQ(kTestData, client()->received_data());
705 } 704 }
706 705
707 } // namespace 706 } // namespace
708 } // namespace content 707 } // namespace content
OLDNEW
« no previous file with comments | « content/child/web_url_loader_impl.cc ('k') | content/child/webcrypto/openssl/aes_cbc_openssl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698