Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: content/child/web_url_loader_impl_unittest.cc

Issue 671663002: Standardize usage of virtual/override/final in content/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/child/web_url_loader_impl.cc ('k') | content/child/webcrypto/openssl/aes_cbc_openssl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/child/web_url_loader_impl_unittest.cc
diff --git a/content/child/web_url_loader_impl_unittest.cc b/content/child/web_url_loader_impl_unittest.cc
index 07eb1da2c38c25907dc1e692366571e1dab8c83d..a7e57e43080821b6809f9d193fb247dd1e7994d2 100644
--- a/content/child/web_url_loader_impl_unittest.cc
+++ b/content/child/web_url_loader_impl_unittest.cc
@@ -68,34 +68,34 @@ class TestBridge : public ResourceLoaderBridge,
url_(info.url) {
}
- virtual ~TestBridge() {}
+ ~TestBridge() override {}
// ResourceLoaderBridge implementation:
- virtual void SetRequestBody(ResourceRequestBody* request_body) override {}
+ void SetRequestBody(ResourceRequestBody* request_body) override {}
- virtual bool Start(RequestPeer* peer) override {
+ bool Start(RequestPeer* peer) override {
EXPECT_FALSE(peer_);
peer_ = peer;
return true;
}
- virtual void Cancel() override {
+ void Cancel() override {
EXPECT_FALSE(canceled_);
canceled_ = true;
}
- virtual void SetDefersLoading(bool value) override {}
+ void SetDefersLoading(bool value) override {}
- virtual void DidChangePriority(net::RequestPriority new_priority,
- int intra_priority_value) override {}
+ void DidChangePriority(net::RequestPriority new_priority,
+ int intra_priority_value) override {}
- virtual bool AttachThreadedDataReceiver(
+ bool AttachThreadedDataReceiver(
blink::WebThreadedDataReceiver* threaded_data_receiver) override {
NOTREACHED();
return false;
}
- virtual void SyncLoad(SyncLoadResponse* response) override {}
+ void SyncLoad(SyncLoadResponse* response) override {}
RequestPeer* peer() { return peer_; }
@@ -114,11 +114,10 @@ class TestBridge : public ResourceLoaderBridge,
class TestResourceDispatcher : public ResourceDispatcher {
public:
TestResourceDispatcher() : ResourceDispatcher(NULL) {}
- virtual ~TestResourceDispatcher() {}
+ ~TestResourceDispatcher() override {}
// ResourceDispatcher implementation:
- virtual ResourceLoaderBridge* CreateBridge(
- const RequestInfo& request_info) override {
+ ResourceLoaderBridge* CreateBridge(const RequestInfo& request_info) override {
EXPECT_FALSE(bridge_.get());
TestBridge* bridge = new TestBridge(request_info);
bridge_ = bridge->AsWeakPtr();
« no previous file with comments | « content/child/web_url_loader_impl.cc ('k') | content/child/webcrypto/openssl/aes_cbc_openssl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698