Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2039)

Unified Diff: content/shell/renderer/test_runner/mock_webrtc_peer_connection_handler.cc

Issue 671663002: Standardize usage of virtual/override/final in content/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/renderer/test_runner/mock_webrtc_peer_connection_handler.cc
diff --git a/content/shell/renderer/test_runner/mock_webrtc_peer_connection_handler.cc b/content/shell/renderer/test_runner/mock_webrtc_peer_connection_handler.cc
index 34e889f36dab4fc8b71a090c1722c5137025fe8c..1e7746791380e0808e83947a7278d6c368959259 100644
--- a/content/shell/renderer/test_runner/mock_webrtc_peer_connection_handler.cc
+++ b/content/shell/renderer/test_runner/mock_webrtc_peer_connection_handler.cc
@@ -35,7 +35,7 @@ class RTCSessionDescriptionRequestSuccededTask
request_(request),
result_(result) {}
- virtual void RunIfValid() override { request_.requestSucceeded(result_); }
+ void RunIfValid() override { request_.requestSucceeded(result_); }
private:
WebRTCSessionDescriptionRequest request_;
@@ -51,7 +51,7 @@ class RTCSessionDescriptionRequestFailedTask
: WebMethodTask<MockWebRTCPeerConnectionHandler>(object),
request_(request) {}
- virtual void RunIfValid() override { request_.requestFailed("TEST_ERROR"); }
+ void RunIfValid() override { request_.requestFailed("TEST_ERROR"); }
private:
WebRTCSessionDescriptionRequest request_;
@@ -67,7 +67,7 @@ class RTCStatsRequestSucceededTask
request_(request),
response_(response) {}
- virtual void RunIfValid() override { request_.requestSucceeded(response_); }
+ void RunIfValid() override { request_.requestSucceeded(response_); }
private:
blink::WebRTCStatsRequest request_;
@@ -84,7 +84,7 @@ class RTCVoidRequestTask
request_(request),
succeeded_(succeeded) {}
- virtual void RunIfValid() override {
+ void RunIfValid() override {
if (succeeded_)
request_.requestSucceeded();
else
@@ -109,7 +109,7 @@ class RTCPeerConnectionStateTask
connection_state_(connection_state),
gathering_state_(gathering_state) {}
- virtual void RunIfValid() override {
+ void RunIfValid() override {
client_->didChangeICEGatheringState(gathering_state_);
client_->didChangeICEConnectionState(connection_state_);
}
@@ -130,7 +130,7 @@ class RemoteDataChannelTask
client_(client),
delegate_(delegate) {}
- virtual void RunIfValid() override {
+ void RunIfValid() override {
WebRTCDataChannelInit init;
WebRTCDataChannelHandler* remote_data_channel =
new MockWebRTCDataChannelHandler(

Powered by Google App Engine
This is Rietveld 408576698