content/shell/renderer/test_runner/mock_web_user_media_client.cc - Issue 671663002: Standardize usage of virtual/override/final in content/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/renderer/test_runner/mock_web_user_media_client.cc

Issue 671663002: Standardize usage of virtual/override/final in content/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/shell/renderer/test_runner/mock_web_speech_recognizer.cc ('k') | content/shell/renderer/test_runner/mock_webrtc_data_channel_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/renderer/test_runner/mock_web_user_media_client.cc

diff --git a/content/shell/renderer/test_runner/mock_web_user_media_client.cc b/content/shell/renderer/test_runner/mock_web_user_media_client.cc

index 596b9d135e3edd58be5734712202723329d6514b..aa30bc8a9a18f38427b61e02a4261c8c11b0d662 100644

--- a/content/shell/renderer/test_runner/mock_web_user_media_client.cc

+++ b/content/shell/renderer/test_runner/mock_web_user_media_client.cc

@@ -46,7 +46,7 @@ class UserMediaRequestTask : public WebMethodTask<MockWebUserMediaClient> {

DCHECK(!result_.isNull());

}

- virtual void RunIfValid() override { request_.requestSucceeded(result_); }

+ void RunIfValid() override { request_.requestSucceeded(result_); }

private:

WebUserMediaRequest request_;

@@ -65,9 +65,7 @@ class UserMediaRequestConstraintFailedTask

request_(request),

constraint_(constraint) {}

- virtual void RunIfValid() override {

- request_.requestFailedConstraint(constraint_);

- }

+ void RunIfValid() override { request_.requestFailedConstraint(constraint_); }

private:

WebUserMediaRequest request_;

@@ -84,7 +82,7 @@ class UserMediaRequestPermissionDeniedTask

: WebMethodTask<MockWebUserMediaClient>(object),

request_(request) {}

- virtual void RunIfValid() override { request_.requestFailed(); }

+ void RunIfValid() override { request_.requestFailed(); }

private:

WebUserMediaRequest request_;

@@ -101,7 +99,7 @@ class MediaDevicesRequestTask : public WebMethodTask<MockWebUserMediaClient> {

request_(request),

result_(result) {}

- virtual void RunIfValid() override { request_.requestSucceeded(result_); }

+ void RunIfValid() override { request_.requestSucceeded(result_); }

private:

WebMediaDevicesRequest request_;

@@ -119,7 +117,7 @@ class SourcesRequestTask : public WebMethodTask<MockWebUserMediaClient> {

request_(request),

result_(result) {}

- virtual void RunIfValid() override { request_.requestSucceeded(result_); }

+ void RunIfValid() override { request_.requestSucceeded(result_); }

private:

WebMediaStreamTrackSourcesRequest request_;