content/child/service_worker/service_worker_dispatcher.h - Issue 671663002: Standardize usage of virtual/override/final in content/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/service_worker/service_worker_dispatcher.h

Issue 671663002: Standardize usage of virtual/override/final in content/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/child/service_worker/service_worker_dispatcher.h

diff --git a/content/child/service_worker/service_worker_dispatcher.h b/content/child/service_worker/service_worker_dispatcher.h

index 8e8dd681428c555c6b1f62fe57993f7e8dabb201..2d01452fa6952bafa18493154c2faf94ee3b5127 100644

--- a/content/child/service_worker/service_worker_dispatcher.h

+++ b/content/child/service_worker/service_worker_dispatcher.h

@@ -52,7 +52,7 @@ class ServiceWorkerDispatcher : public WorkerTaskRunner::Observer {

WebServiceWorkerGetRegistrationCallbacks;

explicit ServiceWorkerDispatcher(ThreadSafeSender* thread_safe_sender);

- virtual ~ServiceWorkerDispatcher();

+ ~ServiceWorkerDispatcher() override;

void OnMessageReceived(const IPC::Message& msg);

bool Send(IPC::Message* msg);

@@ -147,7 +147,7 @@ class ServiceWorkerDispatcher : public WorkerTaskRunner::Observer {

friend class WebServiceWorkerRegistrationImpl;

// WorkerTaskRunner::Observer implementation.

- virtual void OnWorkerRunLoopStopped() override;

+ void OnWorkerRunLoopStopped() override;

void OnAssociateRegistration(int thread_id,

int provider_id,

« no previous file with comments | « content/child/resource_dispatcher_unittest.cc ('k') | content/child/service_worker/service_worker_message_filter.h » ('j') | no next file with comments »