Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Unified Diff: content/public/browser/browser_message_filter.cc

Issue 671663002: Standardize usage of virtual/override/final in content/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/browser/browser_message_filter.h ('k') | content/public/browser/download_item.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/browser_message_filter.cc
diff --git a/content/public/browser/browser_message_filter.cc b/content/public/browser/browser_message_filter.cc
index df9026d5ef7705398d7d69a7e2ebd2b3db9c9069..e4cf09407c7a824b8692fb3b1408a3ede85fbec2 100644
--- a/content/public/browser/browser_message_filter.cc
+++ b/content/public/browser/browser_message_filter.cc
@@ -27,29 +27,27 @@ class BrowserMessageFilter::Internal : public IPC::MessageFilter {
explicit Internal(BrowserMessageFilter* filter) : filter_(filter) {}
private:
- virtual ~Internal() {}
+ ~Internal() override {}
// IPC::MessageFilter implementation:
- virtual void OnFilterAdded(IPC::Sender* sender) override {
+ void OnFilterAdded(IPC::Sender* sender) override {
filter_->sender_ = sender;
filter_->OnFilterAdded(sender);
}
- virtual void OnFilterRemoved() override {
- filter_->OnFilterRemoved();
- }
+ void OnFilterRemoved() override { filter_->OnFilterRemoved(); }
- virtual void OnChannelClosing() override {
+ void OnChannelClosing() override {
filter_->sender_ = NULL;
filter_->OnChannelClosing();
}
- virtual void OnChannelConnected(int32 peer_pid) override {
+ void OnChannelConnected(int32 peer_pid) override {
filter_->peer_pid_ = peer_pid;
filter_->OnChannelConnected(peer_pid);
}
- virtual bool OnMessageReceived(const IPC::Message& message) override {
+ bool OnMessageReceived(const IPC::Message& message) override {
BrowserThread::ID thread = BrowserThread::IO;
filter_->OverrideThreadForMessage(message, &thread);
@@ -78,7 +76,7 @@ class BrowserMessageFilter::Internal : public IPC::MessageFilter {
return true;
}
- virtual bool GetSupportedMessageClasses(
+ bool GetSupportedMessageClasses(
std::vector<uint32>* supported_message_classes) const override {
supported_message_classes->assign(
filter_->message_classes_to_filter().begin(),
« no previous file with comments | « content/public/browser/browser_message_filter.h ('k') | content/public/browser/download_item.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698