Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(875)

Unified Diff: content/public/test/browser_test_utils.cc

Issue 671663002: Standardize usage of virtual/override/final in content/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/test/browser_test_utils.h ('k') | content/public/test/content_browser_test.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/test/browser_test_utils.cc
diff --git a/content/public/test/browser_test_utils.cc b/content/public/test/browser_test_utils.cc
index 563847ed21bce1d6d3c31aec7f6b78122119cc8b..c15edd4aae5bb764b0be5618fe4ed92a4537cc24 100644
--- a/content/public/test/browser_test_utils.cc
+++ b/content/public/test/browser_test_utils.cc
@@ -65,9 +65,9 @@ class DOMOperationObserver : public NotificationObserver,
message_loop_runner_ = new MessageLoopRunner;
}
- virtual void Observe(int type,
- const NotificationSource& source,
- const NotificationDetails& details) override {
+ void Observe(int type,
+ const NotificationSource& source,
+ const NotificationDetails& details) override {
DCHECK(type == NOTIFICATION_DOM_OPERATION_RESPONSE);
Details<DomOperationNotificationDetails> dom_op_details(details);
response_ = dom_op_details->json;
@@ -76,7 +76,7 @@ class DOMOperationObserver : public NotificationObserver,
}
// Overridden from WebContentsObserver:
- virtual void RenderProcessGone(base::TerminationStatus status) override {
+ void RenderProcessGone(base::TerminationStatus status) override {
message_loop_runner_->Quit();
}
@@ -104,15 +104,11 @@ class InterstitialObserver : public content::WebContentsObserver {
attach_callback_(attach_callback),
detach_callback_(detach_callback) {
}
- virtual ~InterstitialObserver() {}
+ ~InterstitialObserver() override {}
// WebContentsObserver methods:
- virtual void DidAttachInterstitialPage() override {
- attach_callback_.Run();
- }
- virtual void DidDetachInterstitialPage() override {
- detach_callback_.Run();
- }
+ void DidAttachInterstitialPage() override { attach_callback_.Run(); }
+ void DidDetachInterstitialPage() override { detach_callback_.Run(); }
private:
base::Closure attach_callback_;
« no previous file with comments | « content/public/test/browser_test_utils.h ('k') | content/public/test/content_browser_test.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698