content/shell/renderer/shell_render_view_observer.h - Issue 671663002: Standardize usage of virtual/override/final in content/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/renderer/shell_render_view_observer.h

Issue 671663002: Standardize usage of virtual/override/final in content/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/shell/renderer/shell_content_renderer_client.h ('k') | content/shell/renderer/test_runner/accessibility_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/renderer/shell_render_view_observer.h

diff --git a/content/shell/renderer/shell_render_view_observer.h b/content/shell/renderer/shell_render_view_observer.h

index a95ed91c3b6f101b631b6796f8ee7672c00a7803..60f3dda2ed2f21a19a5e4c53e9f63383d68ebd2b 100644

--- a/content/shell/renderer/shell_render_view_observer.h

+++ b/content/shell/renderer/shell_render_view_observer.h

@@ -22,15 +22,15 @@ class RenderView;

class ShellRenderViewObserver : public RenderViewObserver {

public:

explicit ShellRenderViewObserver(RenderView* render_view);

- virtual ~ShellRenderViewObserver();

+ ~ShellRenderViewObserver() override;

private:

// Message handlers.

void OnEchoPong(int id, const std::string& body);

// RenderViewObserver implementation.

- virtual bool OnMessageReceived(const IPC::Message& message) override;

- virtual void DidClearWindowObject(blink::WebLocalFrame* frame) override;

+ bool OnMessageReceived(const IPC::Message& message) override;

+ void DidClearWindowObject(blink::WebLocalFrame* frame) override;

scoped_ptr<IPCEcho> ipc_echo_;

DISALLOW_COPY_AND_ASSIGN(ShellRenderViewObserver);