Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1654)

Unified Diff: content/shell/browser/webkit_test_controller.h

Issue 671663002: Standardize usage of virtual/override/final in content/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/browser/webkit_test_controller.h
diff --git a/content/shell/browser/webkit_test_controller.h b/content/shell/browser/webkit_test_controller.h
index f47a277a636d5caf762576f999cf240d253168b5..925a20838fe8ecf694995d14a6ede22fc5f17594 100644
--- a/content/shell/browser/webkit_test_controller.h
+++ b/content/shell/browser/webkit_test_controller.h
@@ -106,7 +106,7 @@ class WebKitTestController : public base::NonThreadSafe,
static WebKitTestController* Get();
WebKitTestController();
- virtual ~WebKitTestController();
+ ~WebKitTestController() override;
// True if the controller is ready for testing.
bool PrepareForLayoutTest(const GURL& test_url,
@@ -132,20 +132,20 @@ class WebKitTestController : public base::NonThreadSafe,
void DevToolsProcessCrashed();
// WebContentsObserver implementation.
- virtual bool OnMessageReceived(const IPC::Message& message) override;
- virtual void PluginCrashed(const base::FilePath& plugin_path,
- base::ProcessId plugin_pid) override;
- virtual void RenderViewCreated(RenderViewHost* render_view_host) override;
- virtual void RenderProcessGone(base::TerminationStatus status) override;
- virtual void WebContentsDestroyed() override;
+ bool OnMessageReceived(const IPC::Message& message) override;
+ void PluginCrashed(const base::FilePath& plugin_path,
+ base::ProcessId plugin_pid) override;
+ void RenderViewCreated(RenderViewHost* render_view_host) override;
+ void RenderProcessGone(base::TerminationStatus status) override;
+ void WebContentsDestroyed() override;
// NotificationObserver implementation.
- virtual void Observe(int type,
- const NotificationSource& source,
- const NotificationDetails& details) override;
+ void Observe(int type,
+ const NotificationSource& source,
+ const NotificationDetails& details) override;
// GpuDataManagerObserver implementation.
- virtual void OnGpuProcessCrashed(base::TerminationStatus exit_code) override;
+ void OnGpuProcessCrashed(base::TerminationStatus exit_code) override;
private:
enum TestPhase {
« no previous file with comments | « content/shell/browser/shell_web_contents_view_delegate.h ('k') | content/shell/common/shell_content_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698