content/shell/renderer/test_runner/gamepad_controller.cc - Issue 671663002: Standardize usage of virtual/override/final in content/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/renderer/test_runner/gamepad_controller.cc

Issue 671663002: Standardize usage of virtual/override/final in content/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/shell/renderer/test_runner/gamepad_controller.h ('k') | content/shell/renderer/test_runner/mock_color_chooser.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/renderer/test_runner/gamepad_controller.cc

diff --git a/content/shell/renderer/test_runner/gamepad_controller.cc b/content/shell/renderer/test_runner/gamepad_controller.cc

index 38902c4921941f00bd7f5ab2be0b974982d5c7af..3293726441ce486027ac7352e2acf64d62834927 100644

--- a/content/shell/renderer/test_runner/gamepad_controller.cc

+++ b/content/shell/renderer/test_runner/gamepad_controller.cc

@@ -31,10 +31,10 @@ class GamepadControllerBindings

private:

explicit GamepadControllerBindings(

base::WeakPtr<GamepadController> controller);

- virtual ~GamepadControllerBindings();

+ ~GamepadControllerBindings() override;

// gin::Wrappable.

- virtual gin::ObjectTemplateBuilder GetObjectTemplateBuilder(

+ gin::ObjectTemplateBuilder GetObjectTemplateBuilder(

v8::Isolate* isolate) override;

void Connect(int index);