content/shell/browser/shell_login_dialog.h - Issue 671663002: Standardize usage of virtual/override/final in content/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/browser/shell_login_dialog.h

Issue 671663002: Standardize usage of virtual/override/final in content/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/shell/browser/shell_login_dialog.h

diff --git a/content/shell/browser/shell_login_dialog.h b/content/shell/browser/shell_login_dialog.h

index 84b0493819fb3cd2c686581e333d1f1d85ce4715..0004a41888638a3466791c059906fa81e2b9adc5 100644

--- a/content/shell/browser/shell_login_dialog.h

+++ b/content/shell/browser/shell_login_dialog.h

@@ -33,7 +33,7 @@ class ShellLoginDialog : public ResourceDispatcherHostLoginDelegate {

// ResourceDispatcherHostLoginDelegate implementation:

// Threading: IO thread.

- virtual void OnRequestCancelled() override;

+ void OnRequestCancelled() override;

// Called by the platform specific code when the user responds. Public because

// the aforementioned platform specific code may not have access to private

@@ -45,7 +45,7 @@ class ShellLoginDialog : public ResourceDispatcherHostLoginDelegate {

protected:

// Threading: any

- virtual ~ShellLoginDialog();

+ ~ShellLoginDialog() override;

private:

// All the methods that begin with Platform need to be implemented by the

« no previous file with comments | « content/shell/browser/shell_javascript_dialog_manager.h ('k') | content/shell/browser/shell_net_log.h » ('j') | no next file with comments »