content/shell/renderer/layout_test/gc_controller.h - Issue 671663002: Standardize usage of virtual/override/final in content/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/renderer/layout_test/gc_controller.h

Issue 671663002: Standardize usage of virtual/override/final in content/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/shell/renderer/ipc_echo.cc ('k') | content/shell/renderer/layout_test/layout_test_content_renderer_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/renderer/layout_test/gc_controller.h

diff --git a/content/shell/renderer/layout_test/gc_controller.h b/content/shell/renderer/layout_test/gc_controller.h

index 1a57e80f5aa4b541459f510c53063ae454ee4cd8..9e09192a5b5e67900f99e132df5ce3c8b3d7bb76 100644

--- a/content/shell/renderer/layout_test/gc_controller.h

+++ b/content/shell/renderer/layout_test/gc_controller.h

@@ -25,10 +25,10 @@ class GCController : public gin::Wrappable<GCController> {

private:

GCController();

- virtual ~GCController();

+ ~GCController() override;

// gin::Wrappable.

- virtual gin::ObjectTemplateBuilder GetObjectTemplateBuilder(

+ gin::ObjectTemplateBuilder GetObjectTemplateBuilder(

v8::Isolate* isolate) override;

void Collect(const gin::Arguments& args);

« no previous file with comments | « content/shell/renderer/ipc_echo.cc ('k') | content/shell/renderer/layout_test/layout_test_content_renderer_client.h » ('j') | no next file with comments »