Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(639)

Unified Diff: content/public/test/test_utils.h

Issue 671663002: Standardize usage of virtual/override/final in content/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/test/test_notification_tracker.h ('k') | content/public/test/test_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/test/test_utils.h
diff --git a/content/public/test/test_utils.h b/content/public/test/test_utils.h
index 230f477ce2d3e45193c36eadc7bde6ec72ed4d16..521e97f65caf95f186be442bae2f94860f13e4bb 100644
--- a/content/public/test/test_utils.h
+++ b/content/public/test/test_utils.h
@@ -148,7 +148,7 @@ class WindowedNotificationObserver : public NotificationObserver {
int notification_type,
const ConditionTestCallbackWithoutSourceAndDetails& callback);
- virtual ~WindowedNotificationObserver();
+ ~WindowedNotificationObserver() override;
// Adds an additional notification type to wait for. The condition will be met
// if any of the registered notification types from their respective sources
@@ -172,9 +172,9 @@ class WindowedNotificationObserver : public NotificationObserver {
}
// NotificationObserver:
- virtual void Observe(int type,
- const NotificationSource& source,
- const NotificationDetails& details) override;
+ void Observe(int type,
+ const NotificationSource& source,
+ const NotificationDetails& details) override;
private:
bool seen_;
@@ -204,12 +204,11 @@ class WindowedNotificationObserver : public NotificationObserver {
class InProcessUtilityThreadHelper : public BrowserChildProcessObserver {
public:
InProcessUtilityThreadHelper();
- virtual ~InProcessUtilityThreadHelper();
+ ~InProcessUtilityThreadHelper() override;
private:
- virtual void BrowserChildProcessHostConnected(
- const ChildProcessData& data) override;
- virtual void BrowserChildProcessHostDisconnected(
+ void BrowserChildProcessHostConnected(const ChildProcessData& data) override;
+ void BrowserChildProcessHostDisconnected(
const ChildProcessData& data) override;
int child_thread_count_;
« no previous file with comments | « content/public/test/test_notification_tracker.h ('k') | content/public/test/test_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698