content/test/plugin/plugin_javascript_open_popup.h - Issue 671663002: Standardize usage of virtual/override/final in content/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/test/plugin/plugin_javascript_open_popup.h

Issue 671663002: Standardize usage of virtual/override/final in content/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/test/plugin/plugin_javascript_open_popup.h

diff --git a/content/test/plugin/plugin_javascript_open_popup.h b/content/test/plugin/plugin_javascript_open_popup.h

index f6a4a87545352f9da952b3add18e6deca314c12b..5a40163614b8433f11c99e948645303f66da8c44 100644

--- a/content/test/plugin/plugin_javascript_open_popup.h

+++ b/content/test/plugin/plugin_javascript_open_popup.h

@@ -19,7 +19,7 @@ class ExecuteJavascriptOpenPopupWithPluginTest : public PluginTest {

ExecuteJavascriptOpenPopupWithPluginTest(

NPP id, NPNetscapeFuncs *host_functions);

// NPAPI SetWindow handler.

- virtual NPError SetWindow(NPWindow* window) override;

+ NPError SetWindow(NPWindow* window) override;

private:

bool popup_window_test_started_;

@@ -32,7 +32,7 @@ class ExecuteJavascriptPopupWindowTargetPluginTest : public PluginTest {

ExecuteJavascriptPopupWindowTargetPluginTest(

NPP id, NPNetscapeFuncs *host_functions);

// NPAPI SetWindow handler.

- virtual NPError SetWindow(NPWindow* window) override;

+ NPError SetWindow(NPWindow* window) override;

private:

// Do a platform-specific validation of the passed-in |window|.

« no previous file with comments | « content/test/plugin/plugin_geturl_test.h ('k') | content/test/plugin/plugin_new_fails_test.h » ('j') | no next file with comments »