content/shell/renderer/ipc_echo.cc - Issue 671663002: Standardize usage of virtual/override/final in content/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/renderer/ipc_echo.cc

Issue 671663002: Standardize usage of virtual/override/final in content/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/shell/renderer/ipc_echo.cc

diff --git a/content/shell/renderer/ipc_echo.cc b/content/shell/renderer/ipc_echo.cc

index 0bbd922a104ad53b8c5205552e42563753732f3f..fe60c65f873fb445fc39dc227ec616c4bd8a09cb 100644

--- a/content/shell/renderer/ipc_echo.cc

+++ b/content/shell/renderer/ipc_echo.cc

@@ -28,8 +28,7 @@ public:

int GetLastEchoSize() const;

private:

- virtual gin::ObjectTemplateBuilder GetObjectTemplateBuilder(

- v8::Isolate*) override;

+ gin::ObjectTemplateBuilder GetObjectTemplateBuilder(v8::Isolate*) override;

base::WeakPtr<IPCEcho> native_;

};

« no previous file with comments | « content/shell/geolocation/shell_access_token_store.h ('k') | content/shell/renderer/layout_test/gc_controller.h » ('j') | no next file with comments »