Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1989)

Unified Diff: content/shell/renderer/layout_test/webkit_test_runner.cc

Issue 671663002: Standardize usage of virtual/override/final in content/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/renderer/layout_test/webkit_test_runner.cc
diff --git a/content/shell/renderer/layout_test/webkit_test_runner.cc b/content/shell/renderer/layout_test/webkit_test_runner.cc
index de7dda43ee41cca6758cf4ab8a42763ce7c701dc..9059d8147fe8302942126d27f48daec2663a4740 100644
--- a/content/shell/renderer/layout_test/webkit_test_runner.cc
+++ b/content/shell/renderer/layout_test/webkit_test_runner.cc
@@ -103,9 +103,9 @@ void InvokeTaskHelper(void* context) {
class SyncNavigationStateVisitor : public RenderViewVisitor {
public:
SyncNavigationStateVisitor() {}
- virtual ~SyncNavigationStateVisitor() {}
+ ~SyncNavigationStateVisitor() override {}
- virtual bool Visit(RenderView* render_view) override {
+ bool Visit(RenderView* render_view) override {
SyncNavigationState(render_view);
return true;
}
@@ -119,11 +119,11 @@ class ProxyToRenderViewVisitor : public RenderViewVisitor {
: proxy_(proxy),
render_view_(NULL) {
}
- virtual ~ProxyToRenderViewVisitor() {}
+ ~ProxyToRenderViewVisitor() override {}
RenderView* render_view() const { return render_view_; }
- virtual bool Visit(RenderView* render_view) override {
+ bool Visit(RenderView* render_view) override {
WebKitTestRunner* test_runner = WebKitTestRunner::Get(render_view);
if (!test_runner) {
NOTREACHED();
@@ -147,9 +147,9 @@ class NavigateAwayVisitor : public RenderViewVisitor {
public:
explicit NavigateAwayVisitor(RenderView* main_render_view)
: main_render_view_(main_render_view) {}
- virtual ~NavigateAwayVisitor() {}
+ ~NavigateAwayVisitor() override {}
- virtual bool Visit(RenderView* render_view) override {
+ bool Visit(RenderView* render_view) override {
if (render_view == main_render_view_)
return true;
render_view->GetWebView()->mainFrame()->loadRequest(
@@ -166,9 +166,9 @@ class NavigateAwayVisitor : public RenderViewVisitor {
class UseSynchronousResizeModeVisitor : public RenderViewVisitor {
public:
explicit UseSynchronousResizeModeVisitor(bool enable) : enable_(enable) {}
- virtual ~UseSynchronousResizeModeVisitor() {}
+ ~UseSynchronousResizeModeVisitor() override {}
- virtual bool Visit(RenderView* render_view) override {
+ bool Visit(RenderView* render_view) override {
UseSynchronousResizeMode(render_view, enable_);
return true;
}
« no previous file with comments | « content/shell/renderer/layout_test/webkit_test_runner.h ('k') | content/shell/renderer/shell_content_renderer_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698