content/shell/tools/plugin/Tests/PluginScriptableObjectOverridesAllProperties.cpp - Issue 671663002: Standardize usage of virtual/override/final in content/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/tools/plugin/Tests/PluginScriptableObjectOverridesAllProperties.cpp

Issue 671663002: Standardize usage of virtual/override/final in content/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/shell/tools/plugin/Tests/PluginScriptableNPObjectInvokeDefault.cpp ('k') | content/test/appcache_test_helper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/tools/plugin/Tests/PluginScriptableObjectOverridesAllProperties.cpp

diff --git a/content/shell/tools/plugin/Tests/PluginScriptableObjectOverridesAllProperties.cpp b/content/shell/tools/plugin/Tests/PluginScriptableObjectOverridesAllProperties.cpp

index d21f3a1b4e4006485ea274f09bceb441f301f468..d212e884006ff32314fab2bb399e7d851f092f90 100644

--- a/content/shell/tools/plugin/Tests/PluginScriptableObjectOverridesAllProperties.cpp

+++ b/content/shell/tools/plugin/Tests/PluginScriptableObjectOverridesAllProperties.cpp

@@ -48,9 +48,7 @@ private:

{

}

- virtual ~PluginObject()

- {

- }

+ ~PluginObject() override {}

bool hasProperty(NPIdentifier propertyName)

{

@@ -72,8 +70,7 @@ private:

}

};

- virtual NPError NPP_GetValue(NPPVariable variable, void *value) override

- {

+ NPError NPP_GetValue(NPPVariable variable, void* value) override {

if (variable != NPPVpluginScriptableNPObject)

return NPERR_GENERIC_ERROR;

« no previous file with comments | « content/shell/tools/plugin/Tests/PluginScriptableNPObjectInvokeDefault.cpp ('k') | content/test/appcache_test_helper.h » ('j') | no next file with comments »