content/shell/tools/plugin/Tests/NullNPPGetValuePointer.cpp - Issue 671663002: Standardize usage of virtual/override/final in content/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/tools/plugin/Tests/NullNPPGetValuePointer.cpp

Issue 671663002: Standardize usage of virtual/override/final in content/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/shell/tools/plugin/Tests/NPRuntimeRemoveProperty.cpp ('k') | content/shell/tools/plugin/Tests/PassDifferentNPPStruct.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/tools/plugin/Tests/NullNPPGetValuePointer.cpp

diff --git a/content/shell/tools/plugin/Tests/NullNPPGetValuePointer.cpp b/content/shell/tools/plugin/Tests/NullNPPGetValuePointer.cpp

index 34d4b198e31095fd11098ff8a4237985e79b144b..3e76d240e89b6b000b2a6299119b13bc67eb80cd 100644

--- a/content/shell/tools/plugin/Tests/NullNPPGetValuePointer.cpp

+++ b/content/shell/tools/plugin/Tests/NullNPPGetValuePointer.cpp

@@ -40,8 +40,8 @@ public:

NullNPPGetValuePointer(NPP, const string& identifier);

private:

- virtual NPError NPP_Destroy(NPSavedData**) override;

- virtual NPError NPP_GetValue(NPPVariable, void* value) override;

+ NPError NPP_Destroy(NPSavedData**) override;

+ NPError NPP_GetValue(NPPVariable, void* value) override;

NPP_GetValueProcPtr m_originalNPPGetValuePointer;

};