content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.h - Issue 671663002: Standardize usage of virtual/override/final in content/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.h

Issue 671663002: Standardize usage of virtual/override/final in content/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/common/gpu/client/gpu_memory_buffer_impl_ozone_native_buffer.h ('k') | content/common/gpu/client/gpu_video_decode_accelerator_host.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.h

diff --git a/content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.h b/content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.h

index eb3c9113cbf319d97d152cbf75afc8b2778fc14c..2d28a3ead3b281857c7366b303e5f3976c183412 100644

--- a/content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.h

+++ b/content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.h

@@ -35,17 +35,17 @@ class GpuMemoryBufferImplSharedMemory : public GpuMemoryBufferImpl {

Usage usage);

// Overridden from gfx::GpuMemoryBuffer:

- virtual void* Map() override;

- virtual void Unmap() override;

- virtual uint32 GetStride() const override;

- virtual gfx::GpuMemoryBufferHandle GetHandle() const override;

+ void* Map() override;

+ void Unmap() override;

+ uint32 GetStride() const override;

+ gfx::GpuMemoryBufferHandle GetHandle() const override;

private:

GpuMemoryBufferImplSharedMemory(const gfx::Size& size,

Format format,

const DestructionCallback& callback,

scoped_ptr<base::SharedMemory> shared_memory);

- virtual ~GpuMemoryBufferImplSharedMemory();

+ ~GpuMemoryBufferImplSharedMemory() override;

scoped_ptr<base::SharedMemory> shared_memory_;