content/shell/tools/plugin/Tests/DocumentOpenInDestroyStream.cpp - Issue 671663002: Standardize usage of virtual/override/final in content/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/tools/plugin/Tests/DocumentOpenInDestroyStream.cpp

Issue 671663002: Standardize usage of virtual/override/final in content/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/shell/renderer/test_runner/web_test_proxy.cc ('k') | content/shell/tools/plugin/Tests/EvaluateJSAfterRemovingPluginElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/tools/plugin/Tests/DocumentOpenInDestroyStream.cpp

diff --git a/content/shell/tools/plugin/Tests/DocumentOpenInDestroyStream.cpp b/content/shell/tools/plugin/Tests/DocumentOpenInDestroyStream.cpp

index 24ba0967ffb43d8735ca54769b3e0a2c6fb230b4..b4b2e8f2b51750e5f746eb5133c427fda03ffc4b 100644

--- a/content/shell/tools/plugin/Tests/DocumentOpenInDestroyStream.cpp

+++ b/content/shell/tools/plugin/Tests/DocumentOpenInDestroyStream.cpp

@@ -44,8 +44,7 @@ public:

}

private:

- virtual NPError NPP_DestroyStream(NPStream*, NPReason) override

- {

+ NPError NPP_DestroyStream(NPStream*, NPReason) override {

if (m_shouldOpen) {

testDocumentOpen(m_npp);

m_shouldOpen = false;