Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2282)

Unified Diff: content/shell/renderer/test_runner/mock_web_speech_recognizer.cc

Issue 671663002: Standardize usage of virtual/override/final in content/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/renderer/test_runner/mock_web_speech_recognizer.cc
diff --git a/content/shell/renderer/test_runner/mock_web_speech_recognizer.cc b/content/shell/renderer/test_runner/mock_web_speech_recognizer.cc
index f6ca0f63f5be2ecc5c370ffe3c3ea51ff620f284..7974d5a3047914f0a5ff2e3711c6bf6c1a68fd81 100644
--- a/content/shell/renderer/test_runner/mock_web_speech_recognizer.cc
+++ b/content/shell/renderer/test_runner/mock_web_speech_recognizer.cc
@@ -21,9 +21,9 @@ class ClientCallTask : public MockWebSpeechRecognizer::Task {
ClientCallTask(MockWebSpeechRecognizer* mock, ClientFunctionPointer function)
: MockWebSpeechRecognizer::Task(mock), function_(function) {}
- virtual ~ClientCallTask() {}
+ ~ClientCallTask() override {}
- virtual void run() override {
+ void run() override {
(recognizer_->Client()->*function_)(recognizer_->Handle());
}
@@ -43,9 +43,9 @@ class ResultTask : public MockWebSpeechRecognizer::Task {
transcript_(transcript),
confidence_(confidence) {}
- virtual ~ResultTask() {}
+ ~ResultTask() override {}
- virtual void run() override {
+ void run() override {
blink::WebVector<blink::WebString> transcripts(static_cast<size_t>(1));
blink::WebVector<float> confidences(static_cast<size_t>(1));
transcripts[0] = transcript_;
@@ -72,9 +72,9 @@ class NoMatchTask : public MockWebSpeechRecognizer::Task {
NoMatchTask(MockWebSpeechRecognizer* mock)
: MockWebSpeechRecognizer::Task(mock) {}
- virtual ~NoMatchTask() {}
+ ~NoMatchTask() override {}
- virtual void run() override {
+ void run() override {
recognizer_->Client()->didReceiveNoMatch(
recognizer_->Handle(), blink::WebSpeechRecognitionResult());
}
@@ -91,9 +91,9 @@ class ErrorTask : public MockWebSpeechRecognizer::Task {
const blink::WebString& message)
: MockWebSpeechRecognizer::Task(mock), code_(code), message_(message) {}
- virtual ~ErrorTask() {}
+ ~ErrorTask() override {}
- virtual void run() override {
+ void run() override {
recognizer_->Client()->didReceiveError(
recognizer_->Handle(), message_, code_);
}

Powered by Google App Engine
This is Rietveld 408576698