Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2720)

Unified Diff: content/shell/browser/layout_test/layout_test_javascript_dialog_manager.h

Issue 671663002: Standardize usage of virtual/override/final in content/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/browser/layout_test/layout_test_javascript_dialog_manager.h
diff --git a/content/shell/browser/layout_test/layout_test_javascript_dialog_manager.h b/content/shell/browser/layout_test/layout_test_javascript_dialog_manager.h
index 84ebaced8964bf23b1efca84040fb5ff94829bfb..87b56eb508e94ab28fb8b60c432b74f6ca01c0a2 100644
--- a/content/shell/browser/layout_test/layout_test_javascript_dialog_manager.h
+++ b/content/shell/browser/layout_test/layout_test_javascript_dialog_manager.h
@@ -15,24 +15,22 @@ namespace content {
class LayoutTestJavaScriptDialogManager : public ShellJavaScriptDialogManager {
public:
LayoutTestJavaScriptDialogManager();
- virtual ~LayoutTestJavaScriptDialogManager();
+ ~LayoutTestJavaScriptDialogManager() override;
// JavaScriptDialogManager:
- virtual void RunJavaScriptDialog(
- WebContents* web_contents,
- const GURL& origin_url,
- const std::string& accept_lang,
- JavaScriptMessageType javascript_message_type,
- const base::string16& message_text,
- const base::string16& default_prompt_text,
- const DialogClosedCallback& callback,
- bool* did_suppress_message) override;
-
- virtual void RunBeforeUnloadDialog(
- WebContents* web_contents,
- const base::string16& message_text,
- bool is_reload,
- const DialogClosedCallback& callback) override;
+ void RunJavaScriptDialog(WebContents* web_contents,
+ const GURL& origin_url,
+ const std::string& accept_lang,
+ JavaScriptMessageType javascript_message_type,
+ const base::string16& message_text,
+ const base::string16& default_prompt_text,
+ const DialogClosedCallback& callback,
+ bool* did_suppress_message) override;
+
+ void RunBeforeUnloadDialog(WebContents* web_contents,
+ const base::string16& message_text,
+ bool is_reload,
+ const DialogClosedCallback& callback) override;
private:
DISALLOW_COPY_AND_ASSIGN(LayoutTestJavaScriptDialogManager);

Powered by Google App Engine
This is Rietveld 408576698