Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1079)

Unified Diff: content/public/test/browser_test_utils.h

Issue 671663002: Standardize usage of virtual/override/final in content/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/test/browser_test_base.cc ('k') | content/public/test/browser_test_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/test/browser_test_utils.h
diff --git a/content/public/test/browser_test_utils.h b/content/public/test/browser_test_utils.h
index 4ad87600760a0961cee7edeafdb15677ab91088e..5a0882f5b911acfb1114c8ae66f31f52fb2fdea4 100644
--- a/content/public/test/browser_test_utils.h
+++ b/content/public/test/browser_test_utils.h
@@ -228,7 +228,7 @@ class TitleWatcher : public WebContentsObserver {
// will wait for.
TitleWatcher(WebContents* web_contents,
const base::string16& expected_title);
- virtual ~TitleWatcher();
+ ~TitleWatcher() override;
// Adds another title to watch for.
void AlsoWaitForTitle(const base::string16& expected_title);
@@ -240,8 +240,8 @@ class TitleWatcher : public WebContentsObserver {
private:
// Overridden WebContentsObserver methods.
- virtual void DidStopLoading(RenderViewHost* render_view_host) override;
- virtual void TitleWasSet(NavigationEntry* entry, bool explicit_set) override;
+ void DidStopLoading(RenderViewHost* render_view_host) override;
+ void TitleWasSet(NavigationEntry* entry, bool explicit_set) override;
void TestTitle();
@@ -258,14 +258,14 @@ class TitleWatcher : public WebContentsObserver {
class WebContentsDestroyedWatcher : public WebContentsObserver {
public:
explicit WebContentsDestroyedWatcher(WebContents* web_contents);
- virtual ~WebContentsDestroyedWatcher();
+ ~WebContentsDestroyedWatcher() override;
// Waits until the WebContents is destroyed.
void Wait();
private:
// Overridden WebContentsObserver methods.
- virtual void WebContentsDestroyed() override;
+ void WebContentsDestroyed() override;
scoped_refptr<MessageLoopRunner> message_loop_runner_;
@@ -284,17 +284,17 @@ class RenderProcessHostWatcher : public RenderProcessHostObserver {
WatchType type);
// Waits for the render process that contains the specified web contents.
RenderProcessHostWatcher(WebContents* web_contents, WatchType type);
- virtual ~RenderProcessHostWatcher();
+ ~RenderProcessHostWatcher() override;
// Waits until the renderer process exits.
void Wait();
private:
// Overridden RenderProcessHost::LifecycleObserver methods.
- virtual void RenderProcessExited(RenderProcessHost* host,
- base::TerminationStatus status,
- int exit_code) override;
- virtual void RenderProcessHostDestroyed(RenderProcessHost* host) override;
+ void RenderProcessExited(RenderProcessHost* host,
+ base::TerminationStatus status,
+ int exit_code) override;
+ void RenderProcessHostDestroyed(RenderProcessHost* host) override;
RenderProcessHost* render_process_host_;
WatchType type_;
@@ -312,7 +312,7 @@ class DOMMessageQueue : public NotificationObserver {
// DOMAutomationController. Do not construct this until the browser has
// started.
DOMMessageQueue();
- virtual ~DOMMessageQueue();
+ ~DOMMessageQueue() override;
// Removes all messages in the message queue.
void ClearQueue();
@@ -322,9 +322,9 @@ class DOMMessageQueue : public NotificationObserver {
bool WaitForMessage(std::string* message) WARN_UNUSED_RESULT;
// Overridden NotificationObserver methods.
- virtual void Observe(int type,
- const NotificationSource& source,
- const NotificationDetails& details) override;
+ void Observe(int type,
+ const NotificationSource& source,
+ const NotificationDetails& details) override;
private:
NotificationRegistrar registrar_;
« no previous file with comments | « content/public/test/browser_test_base.cc ('k') | content/public/test/browser_test_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698