Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(870)

Unified Diff: content/plugin/plugin_channel.h

Issue 671663002: Standardize usage of virtual/override/final in content/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/gpu/in_process_gpu_thread.h ('k') | content/plugin/plugin_channel.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/plugin/plugin_channel.h
diff --git a/content/plugin/plugin_channel.h b/content/plugin/plugin_channel.h
index 27e0e93cd19efd7fbb666d5bd276b61f0036f1b4..d3106b347c52c334ea02f2834cb95161f6d40896 100644
--- a/content/plugin/plugin_channel.h
+++ b/content/plugin/plugin_channel.h
@@ -33,17 +33,17 @@ class PluginChannel : public NPChannelBase {
static void NotifyRenderersOfPendingShutdown();
// IPC::Listener:
- virtual bool Send(IPC::Message* msg) override;
- virtual bool OnMessageReceived(const IPC::Message& message) override;
- virtual void OnChannelError() override;
+ bool Send(IPC::Message* msg) override;
+ bool OnMessageReceived(const IPC::Message& message) override;
+ void OnChannelError() override;
int renderer_id() { return renderer_id_; }
- virtual int GenerateRouteID() override;
+ int GenerateRouteID() override;
// Returns the event that's set when a call to the renderer causes a modal
// dialog to come up.
- virtual base::WaitableEvent* GetModalDialogEvent(int render_view_id) override;
+ base::WaitableEvent* GetModalDialogEvent(int render_view_id) override;
bool in_send() { return in_send_ != 0; }
@@ -57,13 +57,13 @@ class PluginChannel : public NPChannelBase {
#endif
protected:
- virtual ~PluginChannel();
+ ~PluginChannel() override;
// NPChannelBase::
- virtual void CleanUp() override;
- virtual bool Init(base::MessageLoopProxy* ipc_message_loop,
- bool create_pipe_now,
- base::WaitableEvent* shutdown_event) override;
+ void CleanUp() override;
+ bool Init(base::MessageLoopProxy* ipc_message_loop,
+ bool create_pipe_now,
+ base::WaitableEvent* shutdown_event) override;
private:
class MessageFilter;
@@ -71,7 +71,7 @@ class PluginChannel : public NPChannelBase {
// Called on the plugin thread
PluginChannel();
- virtual bool OnControlMessageReceived(const IPC::Message& msg) override;
+ bool OnControlMessageReceived(const IPC::Message& msg) override;
static NPChannelBase* ClassFactory() { return new PluginChannel(); }
« no previous file with comments | « content/gpu/in_process_gpu_thread.h ('k') | content/plugin/plugin_channel.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698