content/shell/tools/plugin/Tests/LeakWindowScriptableObject.cpp - Issue 671663002: Standardize usage of virtual/override/final in content/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/tools/plugin/Tests/LeakWindowScriptableObject.cpp

Issue 671663002: Standardize usage of virtual/override/final in content/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/shell/tools/plugin/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp ('k') | content/shell/tools/plugin/Tests/LogNPPSetWindow.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/tools/plugin/Tests/LeakWindowScriptableObject.cpp

diff --git a/content/shell/tools/plugin/Tests/LeakWindowScriptableObject.cpp b/content/shell/tools/plugin/Tests/LeakWindowScriptableObject.cpp

index bfc1a27e16575b11032064e9ddfe3ff114e75cab..3b68c5ba72e2b54b218b231bddd673df104fe8c1 100644

--- a/content/shell/tools/plugin/Tests/LeakWindowScriptableObject.cpp

+++ b/content/shell/tools/plugin/Tests/LeakWindowScriptableObject.cpp

@@ -14,12 +14,12 @@ public:

}

private:

- virtual NPError NPP_New(NPMIMEType pluginType,

- uint16_t mode,

- int16_t argc,

- char* argn[],

- char* argv[],

- NPSavedData* saved) override {

+ NPError NPP_New(NPMIMEType pluginType,

+ uint16_t mode,

+ int16_t argc,

+ char* argn[],

+ char* argv[],

+ NPSavedData* saved) override {

// Get a new reference to the window script object.

NPObject* window;

if (NPN_GetValue(NPNVWindowNPObject, &window) != NPERR_NO_ERROR) {