content/shell/renderer/test_runner/web_test_proxy.cc - Issue 671663002: Standardize usage of virtual/override/final in content/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/renderer/test_runner/web_test_proxy.cc

Issue 671663002: Standardize usage of virtual/override/final in content/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/shell/renderer/test_runner/web_ax_object_proxy.h ('k') | content/shell/tools/plugin/Tests/DocumentOpenInDestroyStream.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/renderer/test_runner/web_test_proxy.cc

diff --git a/content/shell/renderer/test_runner/web_test_proxy.cc b/content/shell/renderer/test_runner/web_test_proxy.cc

index 860e110fdb0a70b1fad5b2d0a9a78c48fcc326dd..fbf4881d51c9dab2914356ae23a3a0a88dd12ef6 100644

--- a/content/shell/renderer/test_runner/web_test_proxy.cc

+++ b/content/shell/renderer/test_runner/web_test_proxy.cc

@@ -87,7 +87,7 @@ class HostMethodTask : public WebMethodTask<WebTestProxyBase> {

HostMethodTask(WebTestProxyBase* object, CallbackMethodType callback)

: WebMethodTask<WebTestProxyBase>(object), callback_(callback) {}

- virtual void RunIfValid() override { (object_->*callback_)(); }

+ void RunIfValid() override { (object_->*callback_)(); }

private:

CallbackMethodType callback_;