Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Unified Diff: content/common/child_process_host_impl.h

Issue 671663002: Standardize usage of virtual/override/final in content/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/child/worker_thread_task_runner.h ('k') | content/common/gpu/client/command_buffer_proxy_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/child_process_host_impl.h
diff --git a/content/common/child_process_host_impl.h b/content/common/child_process_host_impl.h
index 43e3e2412ca6f11fb3f786c9e4366d02d0213102..0851ad7497ea6ca2b30869e5005f7c2a96532540 100644
--- a/content/common/child_process_host_impl.h
+++ b/content/common/child_process_host_impl.h
@@ -36,7 +36,7 @@ class ChildProcessHostDelegate;
class CONTENT_EXPORT ChildProcessHostImpl : public ChildProcessHost,
public IPC::Listener {
public:
- virtual ~ChildProcessHostImpl();
+ ~ChildProcessHostImpl() override;
// Public and static for reuse by RenderMessageFilter.
static void AllocateSharedMemory(
@@ -55,13 +55,13 @@ class CONTENT_EXPORT ChildProcessHostImpl : public ChildProcessHost,
static int GenerateChildProcessUniqueId();
// ChildProcessHost implementation
- virtual bool Send(IPC::Message* message) override;
- virtual void ForceShutdown() override;
- virtual std::string CreateChannel() override;
- virtual bool IsChannelOpening() override;
- virtual void AddFilter(IPC::MessageFilter* filter) override;
+ bool Send(IPC::Message* message) override;
+ void ForceShutdown() override;
+ std::string CreateChannel() override;
+ bool IsChannelOpening() override;
+ void AddFilter(IPC::MessageFilter* filter) override;
#if defined(OS_POSIX)
- virtual base::ScopedFD TakeClientFileDescriptor() override;
+ base::ScopedFD TakeClientFileDescriptor() override;
#endif
private:
@@ -70,10 +70,10 @@ class CONTENT_EXPORT ChildProcessHostImpl : public ChildProcessHost,
explicit ChildProcessHostImpl(ChildProcessHostDelegate* delegate);
// IPC::Listener methods:
- virtual bool OnMessageReceived(const IPC::Message& msg) override;
- virtual void OnChannelConnected(int32 peer_pid) override;
- virtual void OnChannelError() override;
- virtual void OnBadMessageReceived(const IPC::Message& message) override;
+ bool OnMessageReceived(const IPC::Message& msg) override;
+ void OnChannelConnected(int32 peer_pid) override;
+ void OnChannelError() override;
+ void OnBadMessageReceived(const IPC::Message& message) override;
// Message handlers:
void OnShutdownRequest();
« no previous file with comments | « content/child/worker_thread_task_runner.h ('k') | content/common/gpu/client/command_buffer_proxy_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698