content/test/appcache_test_helper.h - Issue 671663002: Standardize usage of virtual/override/final in content/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/test/appcache_test_helper.h

Issue 671663002: Standardize usage of virtual/override/final in content/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/shell/tools/plugin/Tests/PluginScriptableObjectOverridesAllProperties.cpp ('k') | content/test/browser_test_utils_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/test/appcache_test_helper.h

diff --git a/content/test/appcache_test_helper.h b/content/test/appcache_test_helper.h

index 94747ee11b49aa1c5b56fc03cde4d907bc838b46..5f5221f0a963f97c107b7b6bbccba48ea3a8606d 100644

--- a/content/test/appcache_test_helper.h

+++ b/content/test/appcache_test_helper.h

@@ -20,18 +20,17 @@ namespace content {

class AppCacheTestHelper : public AppCacheStorage::Delegate {

public:

AppCacheTestHelper();

- virtual ~AppCacheTestHelper();

+ ~AppCacheTestHelper() override;

void AddGroupAndCache(AppCacheServiceImpl* appcache_service,

const GURL& manifest_url);

void GetOriginsWithCaches(AppCacheServiceImpl* appcache_service,

std::set<GURL>* origins);

private:

- virtual void OnGroupAndNewestCacheStored(

- AppCacheGroup* group,

- AppCache* newest_cache,

- bool success,

- bool would_exceed_quota) override;

+ void OnGroupAndNewestCacheStored(AppCacheGroup* group,

+ AppCache* newest_cache,

+ bool success,

+ bool would_exceed_quota) override;

void OnGotAppCacheInfo(int rv);

int group_id_;