Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Unified Diff: content/shell/browser/shell_devtools_delegate.h

Issue 671663002: Standardize usage of virtual/override/final in content/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/browser/shell_devtools_delegate.h
diff --git a/content/shell/browser/shell_devtools_delegate.h b/content/shell/browser/shell_devtools_delegate.h
index dfef5864b4ad46998e315a1492cd457cf0b4276d..723340d5b0204a829e114da20c331d2b8bedd853 100644
--- a/content/shell/browser/shell_devtools_delegate.h
+++ b/content/shell/browser/shell_devtools_delegate.h
@@ -18,16 +18,16 @@ class DevToolsHttpHandler;
class ShellDevToolsDelegate : public DevToolsHttpHandlerDelegate {
public:
explicit ShellDevToolsDelegate(BrowserContext* browser_context);
- virtual ~ShellDevToolsDelegate();
+ ~ShellDevToolsDelegate() override;
// Stops http server.
void Stop();
// DevToolsHttpHandlerDelegate implementation.
- virtual std::string GetDiscoveryPageHTML() override;
- virtual bool BundlesFrontendResources() override;
- virtual base::FilePath GetDebugFrontendDir() override;
- virtual scoped_ptr<net::StreamListenSocket> CreateSocketForTethering(
+ std::string GetDiscoveryPageHTML() override;
+ bool BundlesFrontendResources() override;
+ base::FilePath GetDebugFrontendDir() override;
+ scoped_ptr<net::StreamListenSocket> CreateSocketForTethering(
net::StreamListenSocket::Delegate* delegate,
std::string* name) override;
@@ -45,19 +45,18 @@ class ShellDevToolsDelegate : public DevToolsHttpHandlerDelegate {
class ShellDevToolsManagerDelegate : public DevToolsManagerDelegate {
public:
explicit ShellDevToolsManagerDelegate(BrowserContext* browser_context);
- virtual ~ShellDevToolsManagerDelegate();
+ ~ShellDevToolsManagerDelegate() override;
// DevToolsManagerDelegate implementation.
- virtual void Inspect(BrowserContext* browser_context,
- DevToolsAgentHost* agent_host) override {}
- virtual void DevToolsAgentStateChanged(DevToolsAgentHost* agent_host,
- bool attached) override {}
- virtual base::DictionaryValue* HandleCommand(
- DevToolsAgentHost* agent_host,
- base::DictionaryValue* command) override;
- virtual scoped_ptr<DevToolsTarget> CreateNewTarget(const GURL& url) override;
- virtual void EnumerateTargets(TargetCallback callback) override;
- virtual std::string GetPageThumbnailData(const GURL& url) override;
+ void Inspect(BrowserContext* browser_context,
+ DevToolsAgentHost* agent_host) override {}
+ void DevToolsAgentStateChanged(DevToolsAgentHost* agent_host,
+ bool attached) override {}
+ base::DictionaryValue* HandleCommand(DevToolsAgentHost* agent_host,
+ base::DictionaryValue* command) override;
+ scoped_ptr<DevToolsTarget> CreateNewTarget(const GURL& url) override;
+ void EnumerateTargets(TargetCallback callback) override;
+ std::string GetPageThumbnailData(const GURL& url) override;
private:
BrowserContext* browser_context_;
« no previous file with comments | « content/shell/browser/shell_content_browser_client.h ('k') | content/shell/browser/shell_devtools_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698