Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 669623008: Remove visible for testing notation for getMobileFolder() (Closed)

Created:
6 years, 2 months ago by Ian Wen
Modified:
6 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove visible for testing notation for getMobileFolder() getMobileFolder() is used in Enhanced Bookmark, and no longer needs to be marked VisibleForTesting to prevent it being stripped during proguard. BUG=NONE Committed: https://crrev.com/d311de611b373057dd30b848528fb20f12fde618 Cr-Commit-Position: refs/heads/master@{#301401}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/BookmarksBridge.java View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/android/bookmarks/bookmarks_bridge.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (2 generated)
Ian Wen
6 years, 2 months ago (2014-10-25 05:48:29 UTC) #2
Kibeom Kim (inactive)
lgtm
6 years, 1 month ago (2014-10-25 08:38:09 UTC) #3
Ted C
lgtm [updated the comment to reflect what visiblefortesting actually does]
6 years, 1 month ago (2014-10-27 15:35:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/669623008/1
6 years, 1 month ago (2014-10-27 17:27:32 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-27 18:17:57 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 18:18:34 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d311de611b373057dd30b848528fb20f12fde618
Cr-Commit-Position: refs/heads/master@{#301401}

Powered by Google App Engine
This is Rietveld 408576698