Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 1320493003: [Custom Tabs]Fix a bug that https is not shown properly (Closed)

Created:
5 years, 3 months ago by Ian Wen
Modified:
5 years, 3 months ago
Reviewers:
Yusuf
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Custom Tabs]Fix a bug that https is not shown properly In android SDK M, android:maxLines no longer works with setSelection. If selection is set to the end, TextView will squeeze the first part to a previous line. This CL changes the urlbar in Custom Tab to use singleLine. BUG=524672 Committed: https://crrev.com/9098c6ed41aed678e27a995b1499790a140b1e9c Cr-Commit-Position: refs/heads/master@{#345530}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/android/java/res/layout/custom_tabs_toolbar.xml View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (2 generated)
Ian Wen
5 years, 3 months ago (2015-08-26 01:46:50 UTC) #2
Yusuf
lgtm lgtm
5 years, 3 months ago (2015-08-26 01:49:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1320493003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1320493003/1
5 years, 3 months ago (2015-08-26 01:54:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-26 02:45:29 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-08-26 02:46:16 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9098c6ed41aed678e27a995b1499790a140b1e9c
Cr-Commit-Position: refs/heads/master@{#345530}

Powered by Google App Engine
This is Rietveld 408576698