Make Contextual Search work in chrome custom tabs

Make Contextual Search work in chrome custom tabs

After we disable new tab creation in custom tabs, the Contextual search
feature has been broken as it relies on the ChromeActivity to create a
tab for it to load the result. This CL makes the custom tab loads the
result directly in the same tab.

BUG=496418
Committed: https://crrev.com/6a91472770fa114eaa33ce9703884a82abd32d13
Cr-Commit-Position: refs/heads/master@{#336292}

[Ian Wen, 2015-06-24 00:11:44]

ianwen@chromium.org changed reviewers:
+ pedrosimonetti@chromium.org, yusufo@chromium.org

[Ian Wen, 2015-06-24 00:11:45]

ptal.

[pedro (no code reviews), 2015-06-24 00:19:15]

lgtm

Thanks Ian for taking care of this!

[Yusuf, 2015-06-24 16:30:02]

https://codereview.chromium.org/1202893003/diff/1/chrome/android/java_staging...
File
chrome/android/java_staging/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
(right):

https://codereview.chromium.org/1202893003/diff/1/chrome/android/java_staging...
chrome/android/java_staging/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java:261:
if (currentTab == null) return false;
Use mTab for this

https://codereview.chromium.org/1202893003/diff/1/chrome/android/java_staging...
chrome/android/java_staging/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java:263:
searchContentViewCore.getWebContents().getNavigationController().getPendingEntry();
Is there nothing else in the navigation entry other than the url?

pedrosimonetti@ do you push any referrer info or any other meta data that is not
in the url to the navigation entry?

[pedro (no code reviews), 2015-06-24 22:05:52]

On 2015/06/24 16:30:02, Yusuf wrote:
>
https://codereview.chromium.org/1202893003/diff/1/chrome/android/java_staging...
> File
>
chrome/android/java_staging/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
> (right):
> 
>
https://codereview.chromium.org/1202893003/diff/1/chrome/android/java_staging...
>
chrome/android/java_staging/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java:261:
> if (currentTab == null) return false;
> Use mTab for this
> 
>
https://codereview.chromium.org/1202893003/diff/1/chrome/android/java_staging...
>
chrome/android/java_staging/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java:263:
>
searchContentViewCore.getWebContents().getNavigationController().getPendingEntry();
> Is there nothing else in the navigation entry other than the url?
> 
> pedrosimonetti@ do you push any referrer info or any other meta data that is
not
> in the url to the navigation entry?

No. Once we figure what is going to be searched, we simply load a regular search
result page for the given query. So, we don't pass any extra information
ourselves.

[Ian Wen, 2015-06-24 22:18:00]

CustomTabActivity behaves very similarly with DocumentActivity, in terms of
overriding createContextualSearch().

yusufo@ ptal. :P

https://codereview.chromium.org/1202893003/diff/1/chrome/android/java_staging...
File
chrome/android/java_staging/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
(right):

https://codereview.chromium.org/1202893003/diff/1/chrome/android/java_staging...
chrome/android/java_staging/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java:261:
if (currentTab == null) return false;
On 2015/06/24 16:30:02, Yusuf wrote:
> Use mTab for this

Done.

https://codereview.chromium.org/1202893003/diff/1/chrome/android/java_staging...
chrome/android/java_staging/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java:263:
searchContentViewCore.getWebContents().getNavigationController().getPendingEntry();
On 2015/06/24 16:30:02, Yusuf wrote:
> Is there nothing else in the navigation entry other than the url?
> 
> pedrosimonetti@ do you push any referrer info or any other meta data that is
not
> in the url to the navigation entry?

Synced with Pedro and his answer is no..

[Yusuf, 2015-06-25 00:14:42]

lgtm

[Ian Wen, 2015-06-25 01:19:47]

The CQ bit was checked by ianwen@chromium.org

[Ian Wen, 2015-06-25 01:19:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
pedrosimonetti@chromium.org
Link to the patchset: https://codereview.chromium.org/1202893003/#ps20001
(title: "use mTab instead")

[commit-bot: I haz the power, 2015-06-25 01:20:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1202893003/20001

[commit-bot: I haz the power, 2015-06-25 01:24:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-25 01:24:06]

Exceeded global retry quota

[Ian Wen, 2015-06-25 22:34:55]

The CQ bit was checked by ianwen@chromium.org

[Ian Wen, 2015-06-25 22:34:56]

The patchset sent to the CQ was uploaded after l-g-t-m from yusufo@chromium.org,
pedrosimonetti@chromium.org
Link to the patchset: https://codereview.chromium.org/1202893003/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2015-06-25 22:36:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1202893003/40001

[commit-bot: I haz the power, 2015-06-25 23:12:13]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-06-25 23:13:13]

Patchset 3 (id:??) landed as
https://crrev.com/6a91472770fa114eaa33ce9703884a82abd32d13
Cr-Commit-Position: refs/heads/master@{#336292}