Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1247513002: [Custom Tabs] Make location bar always anchor left (Closed)

Created:
5 years, 5 months ago by Ian Wen
Modified:
5 years, 5 months ago
Reviewers:
Ted C, Yusuf
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Custom Tabs] Make location bar always anchor left In customtabstoolbar we set the left margin of location bar to be the same size of the security icon. However it the security icon is not visible, this margin should be reset. BUG=512161 Committed: https://crrev.com/bfc410199004d6b2a7051406fab833e5e7c35596 Cr-Commit-Position: refs/heads/master@{#339755}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java View 1 chunk +6 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 9 (3 generated)
Ian Wen
5 years, 5 months ago (2015-07-20 20:47:46 UTC) #2
Ian Wen
ptal at this tiny CL. :P
5 years, 5 months ago (2015-07-21 20:53:26 UTC) #4
Yusuf
lgtm
5 years, 5 months ago (2015-07-21 21:05:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1247513002/1
5 years, 5 months ago (2015-07-21 21:12:05 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-21 21:54:55 UTC) #8
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 21:55:50 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bfc410199004d6b2a7051406fab833e5e7c35596
Cr-Commit-Position: refs/heads/master@{#339755}

Powered by Google App Engine
This is Rietveld 408576698