|
|
DescriptionIntroduce support design library to chrome and roll android_tools/
We want several new widgets from the design library:
1. TextInputLayout
2. NavigationView
3. AppBarLayout
This CL adds the gyp target to chrome_java and roll DEPS for the
third_party folder.
BUG=498585
Committed: https://crrev.com/f322e3cef1ab700bdda8518efe40b474769b94cf
Cr-Commit-Position: refs/heads/master@{#339073}
Patch Set 1 #Patch Set 2 : a small example included #Patch Set 3 : #Patch Set 4 : make gn work #Patch Set 5 : fix gn again. :( #
Total comments: 1
Patch Set 6 : roll android_tools #
Depends on Patchset: Messages
Total messages: 48 (22 generated)
ianwen@chromium.org changed reviewers: + yfriedman@chromium.org
Hello Yaron, could you ptal? Also do you know who I should include to review chrome.gyp? Maybe sky@? Thanks!
On 2015/07/09 18:55:09, Ian Wen wrote: > Hello Yaron, could you ptal? Also do you know who I should include to review > chrome.gyp? Maybe sky@? > > Thanks! Hmm. Will this only be needed for chrome-ui components? Is it not needed for ui/ or content/? Can you either: a) include the changes to use some features from the library in this CL b) (probably preferable) link to the CL using this. sky@ would probably be a good owner but he's ooo
ianwen@chromium.org changed reviewers: + kkimlabs@chromium.org
Yaron: AFAIK, this library will only be used in chrome folder (autofill UI, enhanced bookmark, snackbar are all in chrome folder). I added a minimal example to use this library. In widget folder the there is FloatLabelLayout, which we plan to replace with support.design.TextInputLayout.
lgtm
eb_edit.xml lgtm
ianwen@chromium.org changed reviewers: + thakis@chromium.org
Hello Nico, could you review the change in chrome.gyp? We added the design library to clank and I wonder if you could take a look at the change, since you are one of the owners? Thanks!
lgtm
The CQ bit was checked by ianwen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1225393002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_compile...) cast_shell_android on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_andr...) (exceeded global retry quota)
ianwen@chromium.org changed reviewers: + newt@chromium.org
Hi Newton, could you ptal at the change in chrome/android/res?
eb_edit.xml lgtm
The CQ bit was checked by ianwen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1225393002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...) android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...) android_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_compile...) (exceeded global retry quota)
The CQ bit was checked by ianwen@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from yfriedman@chromium.org, thakis@chromium.org, kkimlabs@chromium.org, newt@chromium.org Link to the patchset: https://codereview.chromium.org/1225393002/#ps40001 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1225393002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
The CQ bit was checked by ianwen@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from yfriedman@chromium.org, thakis@chromium.org, kkimlabs@chromium.org, newt@chromium.org Link to the patchset: https://codereview.chromium.org/1225393002/#ps60001 (title: "make gn work")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1225393002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...) android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
The CQ bit was checked by ianwen@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from yfriedman@chromium.org, thakis@chromium.org, kkimlabs@chromium.org, newt@chromium.org Link to the patchset: https://codereview.chromium.org/1225393002/#ps60002 (title: "fix gn again. :(")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1225393002/60002
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
jbudorick@chromium.org changed reviewers: + jbudorick@chromium.org
https://codereview.chromium.org/1225393002/diff/60002/chrome/chrome.gyp File chrome/chrome.gyp (right): https://codereview.chromium.org/1225393002/diff/60002/chrome/chrome.gyp#newco... chrome/chrome.gyp:615: '../third_party/android_tools/android_tools.gyp:android_support_design_javalib', You need to disable findbugs on this gyp target over in the android_tools repo by setting 'run_findbugs': 0
The CQ bit was checked by ianwen@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from newt@chromium.org, yfriedman@chromium.org, thakis@chromium.org, kkimlabs@chromium.org Link to the patchset: https://codereview.chromium.org/1225393002/#ps90001 (title: "roll android_tools")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1225393002/90001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by ianwen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1225393002/90001
Message was sent while issue was closed.
Committed patchset #6 (id:90001)
Message was sent while issue was closed.
Patchset 6 (id:??) landed as https://crrev.com/f322e3cef1ab700bdda8518efe40b474769b94cf Cr-Commit-Position: refs/heads/master@{#339073} |