Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1012)

Issue 1225393002: Introduce support design library to chrome and roll android_tools/ (Closed)

Created:
5 years, 5 months ago by Ian Wen
Modified:
5 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce support design library to chrome and roll android_tools/ We want several new widgets from the design library: 1. TextInputLayout 2. NavigationView 3. AppBarLayout This CL adds the gyp target to chrome_java and roll DEPS for the third_party folder. BUG=498585 Committed: https://crrev.com/f322e3cef1ab700bdda8518efe40b474769b94cf Cr-Commit-Position: refs/heads/master@{#339073}

Patch Set 1 #

Patch Set 2 : a small example included #

Patch Set 3 : #

Patch Set 4 : make gn work #

Patch Set 5 : fix gn again. :( #

Total comments: 1

Patch Set 6 : roll android_tools #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -5 lines) Patch
M DEPS View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M build/secondary/third_party/android_tools/BUILD.gn View 1 2 3 4 1 chunk +17 lines, -0 lines 0 comments Download
M chrome/android/BUILD.gn View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/res/layout/eb_edit.xml View 1 3 chunks +7 lines, -4 lines 0 comments Download
M chrome/chrome.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tools/android/eclipse/.classpath View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 48 (22 generated)
Ian Wen
Hello Yaron, could you ptal? Also do you know who I should include to review ...
5 years, 5 months ago (2015-07-09 18:55:09 UTC) #2
Yaron
On 2015/07/09 18:55:09, Ian Wen wrote: > Hello Yaron, could you ptal? Also do you ...
5 years, 5 months ago (2015-07-09 19:03:58 UTC) #3
Ian Wen
5 years, 5 months ago (2015-07-10 18:00:52 UTC) #5
Ian Wen
Yaron: AFAIK, this library will only be used in chrome folder (autofill UI, enhanced bookmark, ...
5 years, 5 months ago (2015-07-10 18:06:34 UTC) #6
Yaron
lgtm
5 years, 5 months ago (2015-07-10 18:51:13 UTC) #7
Kibeom Kim (inactive)
eb_edit.xml lgtm
5 years, 5 months ago (2015-07-10 19:14:46 UTC) #8
Ian Wen
Hello Nico, could you review the change in chrome.gyp? We added the design library to ...
5 years, 5 months ago (2015-07-13 22:58:55 UTC) #10
Nico
lgtm
5 years, 5 months ago (2015-07-13 23:17:44 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1225393002/20001
5 years, 5 months ago (2015-07-13 23:29:40 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_compile_dbg/builds/35857) cast_shell_android on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 5 months ago (2015-07-13 23:38:26 UTC) #15
Ian Wen
Hi Newton, could you ptal at the change in chrome/android/res?
5 years, 5 months ago (2015-07-13 23:41:00 UTC) #17
newt (away)
eb_edit.xml lgtm
5 years, 5 months ago (2015-07-13 23:46:32 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1225393002/20001
5 years, 5 months ago (2015-07-13 23:48:26 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/95356) android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 5 months ago (2015-07-13 23:56:03 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1225393002/40001
5 years, 5 months ago (2015-07-14 00:33:34 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/91139)
5 years, 5 months ago (2015-07-14 00:42:39 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1225393002/60001
5 years, 5 months ago (2015-07-14 01:17:11 UTC) #30
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/91171) android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 5 months ago (2015-07-14 01:29:36 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1225393002/60002
5 years, 5 months ago (2015-07-14 01:37:34 UTC) #35
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/96505)
5 years, 5 months ago (2015-07-14 02:37:59 UTC) #37
jbudorick
https://codereview.chromium.org/1225393002/diff/60002/chrome/chrome.gyp File chrome/chrome.gyp (right): https://codereview.chromium.org/1225393002/diff/60002/chrome/chrome.gyp#newcode615 chrome/chrome.gyp:615: '../third_party/android_tools/android_tools.gyp:android_support_design_javalib', You need to disable findbugs on this gyp ...
5 years, 5 months ago (2015-07-15 13:20:28 UTC) #39
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1225393002/90001
5 years, 5 months ago (2015-07-16 00:08:11 UTC) #42
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/86554)
5 years, 5 months ago (2015-07-16 00:53:43 UTC) #44
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1225393002/90001
5 years, 5 months ago (2015-07-16 17:54:18 UTC) #46
commit-bot: I haz the power
Committed patchset #6 (id:90001)
5 years, 5 months ago (2015-07-16 18:01:59 UTC) #47
commit-bot: I haz the power
5 years, 5 months ago (2015-07-16 18:03:13 UTC) #48
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/f322e3cef1ab700bdda8518efe40b474769b94cf
Cr-Commit-Position: refs/heads/master@{#339073}

Powered by Google App Engine
This is Rietveld 408576698