Allow intent picker for external schemes

Allow intent picker for external schemes

For urls that chrome can handle, a custom tab will not fire the intent
picker. Yet for urls with heterogeneous schemes, chrome cannot load
anyway. In this case, we should show an intent picker, in stead of doing
nothing.

BUG=513522
Committed: https://crrev.com/dbb85091f6afe3bed62267f264d4acfdf81ea68c
Cr-Commit-Position: refs/heads/master@{#342924}

[Ian Wen, 2015-08-07 22:26:12]

ianwen@chromium.org changed reviewers:
+ yusufo@chromium.org

[Ian Wen, 2015-08-07 22:26:13]

ptal. We should merge this CL to M45 as it impacts our revenue.

[Yusuf, 2015-08-10 05:37:16]

lgtm with a few style nits.

https://codereview.chromium.org/1282063003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTab.java
(right):

https://codereview.chromium.org/1282063003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTab.java:257:
if (haveDefaultHandler(intent) || isExternalProtocol) {
Can we cleanup the if's here a bit?

if (!hasDefaultHandler && !isExternalProtocol) return false;

if (!getActivity().startActivityIfNeeded) return false;

mHasActivityStarted = true;
return true;

https://codereview.chromium.org/1282063003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTab.java:279:
private boolean haveDefaultHandler(Intent intent) {
has?

[Ian Wen, 2015-08-11 21:42:55]

https://codereview.chromium.org/1282063003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTab.java
(right):

https://codereview.chromium.org/1282063003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTab.java:257:
if (haveDefaultHandler(intent) || isExternalProtocol) {
On 2015/08/10 05:37:15, Yusuf wrote:
> Can we cleanup the if's here a bit?
> 
> if (!hasDefaultHandler && !isExternalProtocol) return false;
> 
> if (!getActivity().startActivityIfNeeded) return false;
> 
> mHasActivityStarted = true;
> return true;

Done.

https://codereview.chromium.org/1282063003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTab.java:279:
private boolean haveDefaultHandler(Intent intent) {
On 2015/08/10 05:37:15, Yusuf wrote:
> has?

Done.

[Ian Wen, 2015-08-11 21:42:58]

The CQ bit was checked by ianwen@chromium.org

[Ian Wen, 2015-08-11 21:42:58]

The patchset sent to the CQ was uploaded after l-g-t-m from yusufo@chromium.org
Link to the patchset: https://codereview.chromium.org/1282063003/#ps40001
(title: " ")

[commit-bot: I haz the power, 2015-08-11 21:43:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1282063003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1282063003/40001

[commit-bot: I haz the power, 2015-08-11 22:52:15]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-08-11 22:52:51]

Patchset 3 (id:??) landed as
https://crrev.com/dbb85091f6afe3bed62267f264d4acfdf81ea68c
Cr-Commit-Position: refs/heads/master@{#342924}