Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Issue 1370363003: Fix a crash that proguard truncates the package name of gifplayer (Closed)

Created:
5 years, 2 months ago by Ian Wen
Modified:
5 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a crash that proguard truncates the package name of gifplayer An animated doodle crash has been observed on release builds because gifplayer's package name is truncated by proguard. This CL does a quick fix for that. BUG=537066 Committed: https://crrev.com/8899e6679c8d9ce3bf6b719981e476c9fb8089e1 Cr-Commit-Position: refs/heads/master@{#351451}

Patch Set 1 #

Patch Set 2 : a more correct less hacky approach #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/android/java/proguard.flags View 1 1 chunk +4 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (3 generated)
Ian Wen
kerz@ this is a quick fix that solves the crash and it should be landed ...
5 years, 2 months ago (2015-09-29 19:22:38 UTC) #2
kerz_chromium
lgtm
5 years, 2 months ago (2015-09-29 19:56:58 UTC) #3
Ian Wen
newt@: ptal the second patchset. kerz@: both patchset is eligible to be merged to the ...
5 years, 2 months ago (2015-09-29 22:05:02 UTC) #4
newt (away)
patch set 2 lgtm
5 years, 2 months ago (2015-09-29 23:27:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1370363003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1370363003/20001
5 years, 2 months ago (2015-09-29 23:28:18 UTC) #8
Ian Wen
An instrumentation test will be on its way. The crash like today's should have been ...
5 years, 2 months ago (2015-09-29 23:29:25 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-09-30 00:33:02 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-09-30 00:33:51 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8899e6679c8d9ce3bf6b719981e476c9fb8089e1
Cr-Commit-Position: refs/heads/master@{#351451}

Powered by Google App Engine
This is Rietveld 408576698