Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1226833010: Clean up custom tab toolbar ellisizing and animation (Closed)

Created:
5 years, 5 months ago by Ian Wen
Modified:
5 years, 5 months ago
Reviewers:
Yusuf
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up custom tab toolbar ellisizing and animation This CL uses android:ellipsize to let the title bar show '...' if it is too long. This CL also fixes a bug that if updateSecurityIcon() is called twice quickly, we double show the urlbar animation. BUG=506326 Committed: https://crrev.com/444738fe2024c5df902b43d7266f1ba4d241b809 Cr-Commit-Position: refs/heads/master@{#337901}

Patch Set 1 #

Total comments: 2

Patch Set 2 : revert padding change #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -23 lines) Patch
M chrome/android/java/res/layout/custom_tabs_toolbar.xml View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java View 1 2 3 chunks +1 line, -23 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 13 (5 generated)
Ian Wen
ptal. :) RTL patch will be uploaded right away.
5 years, 5 months ago (2015-07-08 18:37:59 UTC) #2
Yusuf
lgtm after we add the padding back in https://codereview.chromium.org/1226833010/diff/1/chrome/android/java/res/layout/custom_tabs_toolbar.xml File chrome/android/java/res/layout/custom_tabs_toolbar.xml (left): https://codereview.chromium.org/1226833010/diff/1/chrome/android/java/res/layout/custom_tabs_toolbar.xml#oldcode35 chrome/android/java/res/layout/custom_tabs_toolbar.xml:35: android:paddingEnd="@dimen/toolbar_edge_padding" ...
5 years, 5 months ago (2015-07-08 18:52:13 UTC) #3
Ian Wen
https://codereview.chromium.org/1226833010/diff/1/chrome/android/java/res/layout/custom_tabs_toolbar.xml File chrome/android/java/res/layout/custom_tabs_toolbar.xml (left): https://codereview.chromium.org/1226833010/diff/1/chrome/android/java/res/layout/custom_tabs_toolbar.xml#oldcode35 chrome/android/java/res/layout/custom_tabs_toolbar.xml:35: android:paddingEnd="@dimen/toolbar_edge_padding" On 2015/07/08 18:52:13, Yusuf wrote: > we actually ...
5 years, 5 months ago (2015-07-08 18:52:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1226833010/20001
5 years, 5 months ago (2015-07-08 18:54:17 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/43032) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 5 months ago (2015-07-08 18:57:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1226833010/40001
5 years, 5 months ago (2015-07-08 19:57:44 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 5 months ago (2015-07-08 20:43:29 UTC) #12
commit-bot: I haz the power
5 years, 5 months ago (2015-07-08 20:44:28 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/444738fe2024c5df902b43d7266f1ba4d241b809
Cr-Commit-Position: refs/heads/master@{#337901}

Powered by Google App Engine
This is Rietveld 408576698