Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 1292693002: Fix Custom Action Bar for custom tabs on tablet (Closed)

Created:
5 years, 4 months ago by Ian Wen
Modified:
5 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix Custom Action Bar for custom tabs on tablet Custom tabs on tablet is special in that it does not have a tab strip. Therefore ContextualMenuBar will calculate the wrong offset when animating the bar. BUG=510284 Committed: https://crrev.com/402517c6677e81adf93d11462aeb1b86bfbf9f8a Cr-Commit-Position: refs/heads/master@{#343437}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -3 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ContextualMenuBar.java View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java View 2 chunks +5 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (2 generated)
Ian Wen
dtrainor@chromium.org: Please review changes in yusufo@chromium.org: Please review changes in
5 years, 4 months ago (2015-08-14 00:38:13 UTC) #2
David Trainor- moved to gerrit
lgtm
5 years, 4 months ago (2015-08-14 00:39:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1292693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1292693002/1
5 years, 4 months ago (2015-08-14 17:35:28 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-14 18:21:49 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-14 18:22:24 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/402517c6677e81adf93d11462aeb1b86bfbf9f8a
Cr-Commit-Position: refs/heads/master@{#343437}

Powered by Google App Engine
This is Rietveld 408576698