Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 1327193004: Let WebRTC notification not show "touch to return" in custom tab (Closed)

Created:
5 years, 3 months ago by Ian Wen
Modified:
5 years, 3 months ago
Reviewers:
gone
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Let WebRTC notification not show "touch to return" in custom tab If the WebRTC is initiated from a custom tab, there is no way to return to the tab by clicking the notification. This CL fixes the string discrepency by removing it. BUG=524855 Committed: https://crrev.com/6f074dddc0a530ead7658a082da76b0de4c0075c Cr-Commit-Position: refs/heads/master@{#348031}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/media/MediaCaptureNotificationService.java View 1 chunk +7 lines, -5 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (2 generated)
Ian Wen
PTAL.
5 years, 3 months ago (2015-09-09 22:08:52 UTC) #2
gone
lgtm
5 years, 3 months ago (2015-09-09 22:10:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1327193004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1327193004/1
5 years, 3 months ago (2015-09-09 22:16:56 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-09 22:58:27 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6f074dddc0a530ead7658a082da76b0de4c0075c Cr-Commit-Position: refs/heads/master@{#348031}
5 years, 3 months ago (2015-09-09 22:59:06 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:04:32 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6f074dddc0a530ead7658a082da76b0de4c0075c
Cr-Commit-Position: refs/heads/master@{#348031}

Powered by Google App Engine
This is Rietveld 408576698